summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-01-28Fix handling of data-modifying CTE subplans in EvalPlanQual.Tom Lane
We can't just skip initializing such subplans, because the referencing CTE node will expect to find the subplan available when it initializes. That in turn means that ExecInitModifyTable must allow the case (which actually it needed to do anyway, since there's no guarantee that ModifyTable is exactly at the top of the CTE plan tree). So move the complaint about not being allowed in EvalPlanQual mode to execution instead of initialization. Testing turned up yet another problem, which is that we'd try to re-initialize the result relation's index list, leading to leaks and dangling pointers. Per report from Phil Sorber. Back-patch to 9.1 where data-modifying CTEs were introduced.
2012-01-28Prevent logging "failed to stat file: success" for temp filesMagnus Hagander
This was broken in commit bc3347484a7bf9eddb98e4352d84599cae9a31c6, the addition of statistics counters for temp files. Reported by Thom Brown
2012-01-28Fix error detection in contrib/pgcrypto's encrypt_iv() and decrypt_iv().Tom Lane
Due to oversights, the encrypt_iv() and decrypt_iv() functions failed to report certain types of invalid-input errors, and would instead return random garbage values. Marko Kreen, per report from Stefan Kaltenbrunner
2012-01-28Undo 8.4-era lobotomization of subquery pullup rules.Tom Lane
After the planner was fixed to convert some IN/EXISTS subqueries into semijoins or antijoins, we had to prevent it from doing that in some cases where the plans risked getting much worse. The reason the plans got worse was that in the unoptimized implementation, subqueries could reference parameters from the outer query at any join level, and so full table scans could be avoided even if they were one or more levels of join below where the semi/anti join would be. Now that we have sufficient mechanism in the planner to handle such cases properly, it should no longer be necessary to play dumb here. This reverts commits 07b9936a0f10d746e5076239813a5e938f2f16be and cd1f0d04bf06938c0ee5728fc8424d62bcf2eef3. The latter was a stopgap fix that wasn't really sufficiently analyzed at the time. Rather than just restricting ourselves to cases where the new join can be stacked on the right-hand input, we should also consider whether it can be stacked on the left-hand input.
2012-01-28Use parameterized paths to generate inner indexscans more flexibly.Tom Lane
This patch fixes the planner so that it can generate nestloop-with- inner-indexscan plans even with one or more levels of joining between the indexscan and the nestloop join that is supplying the parameter. The executor was fixed to handle such cases some time ago, but the planner was not ready. This should improve our plans in many situations where join ordering restrictions formerly forced complete table scans. There is probably a fair amount of tuning work yet to be done, because of various heuristics that have been added to limit the number of parameterized paths considered. However, we are not going to find out what needs to be adjusted until the code gets some real-world use, so it's time to get it in there where it can be tested easily. Note API change for index AM amcostestimate functions. I'm not aware of any non-core index AMs, but if there are any, they will need minor adjustments.
2012-01-27Show default privileges in information schemaPeter Eisentraut
Hitherto, the information schema only showed explicitly granted privileges that were visible in the *acl catalog columns. If no privileges had been granted, the implicit privileges were not shown. To fix that, add an SQL-accessible version of the acldefault() function, and use that inside the aclexplode() calls to substitute the catalog-specific default privilege set for null values. reviewed by Abhijit Menon-Sen
2012-01-27Revert unfortunate whitespace changePeter Eisentraut
In e5e2fc842c418432756d8b5825ff107c6c5fc4c3, blank lines were removed after a comment block, which now looks as though the comment refers to the immediately following code, but it actually refers to the preceding code. So put the blank lines back.
2012-01-27Disallow ALTER DOMAIN on non-domain type everywherePeter Eisentraut
This has been the behavior already in most cases, but through omission, ALTER DOMAIN / OWNER TO and ALTER DOMAIN / SET SCHEMA would silently work on non-domain types as well.
2012-01-27Hide most variable-length fields from Form_pg_* structsPeter Eisentraut
Those fields only appear in the structs so that genbki.pl can create the BKI bootstrap files for the catalogs. But they are not actually usable from C. So hiding them can prevent coding mistakes, saves stack space, and can help the compiler. In certain catalogs, the first variable-length field has been kept visible after manual inspection. These exceptions are noted in C comments. reviewed by Tom Lane
2012-01-27Do not access indclass through Form_pg_indexPeter Eisentraut
Normally, accessing variable-length members of catalog structures past the first one doesn't work at all. Here, it happened to work because indnatts was checked to be 1, and so the defined FormData_pg_index layout, using int2vector[1] and oidvector[1] for variable-length arrays, happened to match the actual memory layout. But it's a very fragile assumption, and it's not in a performance-critical path, so code it properly using heap_getattr() instead. bug analysis by Tom Lane
2012-01-27Document that COUNT(*) might not need a seq scan any more.Robert Haas
Noted by Josh Kupershmidt.
2012-01-27Document that analyzing an empty table doesn't update the statistics.Robert Haas
Per a suggestion from Sergey Konoplev
2012-01-27Initialize the new bgwriterLatch field properly.Heikki Linnakangas
Peter Geoghegan
2012-01-27pg_dump: Move connection-setup code to a separate function.Robert Haas
Parallel dump will need to repeat these steps for each new connection, so it's better to have this logic in its own function. Extracted (with some changes) from a much larger patch by Joachim Wieland.
2012-01-27Fix copy-paste error in docs.Heikki Linnakangas
Dean Rasheed
2012-01-27Fix wording, per Peter GeogheganMagnus Hagander
2012-01-27Mention in the docs that bgwriter now sleeps longer when it has no work to do.Heikki Linnakangas
2012-01-27Fix pg_upgrade --help text for --user to not use a plural cluster name.Bruce Momjian
2012-01-26Adjust tuplesort.c based on the fact that we never use the OS's qsort().Robert Haas
Our own qsort_arg() implementation doesn't have the defect previously observed to affect only QNX 4, so it seems sufficiently to assert that it isn't broken rather than retesting. Also, update a few comments to clarify why it's valuable to retain a tie-break rule based on CTID during index builds. Peter Geoghegan, with slight tweaks by me.
2012-01-26Be more clear when a new column name collides with a system column name.Robert Haas
We now use the same error message for ALTER TABLE .. ADD COLUMN or ALTER TABLE .. RENAME COLUMN that we do for CREATE TABLE. The old message was accurate, but might be confusing to users not aware of our system columns. Vik Reykja, with some changes by me, and further proofreading by Tom Lane
2012-01-26Fix sentence in docs: checkpoints are not done by bgwriter anymore.Heikki Linnakangas
2012-01-26Make bgwriter sleep longer when it has no work to do, to save electricity.Heikki Linnakangas
To make it wake up promptly when activity starts again, backends nudge it by setting a latch in MarkBufferDirty(). The latch is kept set while bgwriter is active, so there is very little overhead from that when the system is busy. It is only armed before going into longer sleep. Peter Geoghegan, with some changes by me.
2012-01-26Add missing #include, to suppress compiler warning.Robert Haas
2012-01-26Fix a copy/pasted typo in several commentsMagnus Hagander
2012-01-26Add deadlock counter to pg_stat_databaseMagnus Hagander
Adds a counter that tracks number of deadlocks that occurred in each database to pg_stat_database. Magnus Hagander, reviewed by Jaime Casanova
2012-01-26Classify DROP operations by whether or not they are user-initiated.Robert Haas
This doesn't do anything useful just yet, but is intended as supporting infrastructure for allowing sepgsql to sensibly check DROP permissions. KaiGai Kohei and Robert Haas
2012-01-26Track temporary file count and size in pg_stat_databaseMagnus Hagander
Add counters for number and size of temporary files used for spill-to-disk queries for each database to the pg_stat_database view. Tomas Vondra, review by Magnus Hagander
2012-01-26Damage control for yesterday's CheckIndexCompatible changes.Robert Haas
Rip out a regression test that doesn't play well with settings put in place by the build farm, and rewrite the code in CheckIndexCompatible in a hopefully more transparent style.
2012-01-26Instrument index-only scans to count heap fetches performed.Robert Haas
Patch by me; review by Tom Lane, Jeff Davis, and Peter Geoghegan.
2012-01-25Have \copy go through SendQueryAlvaro Herrera
This enables a bunch of features, notably ON_ERROR_ROLLBACK. It also makes COPY failure (either in the server or psql) as a whole behave more sanely in psql. Additionally, having more commands in the same command line as COPY works better (though since psql splits lines at semicolons, this doesn't matter much unless you're using -c). Also tighten a couple of switches on PQresultStatus() to add PGRES_COPY_BOTH support and stop assuming that unknown statuses received are errors; have those print diagnostics where warranted. Author: Noah Misch
2012-01-25Make CheckIndexCompatible simpler and more bullet-proof.Robert Haas
This gives up the "don't rewrite the index" behavior in a couple of relatively unimportant cases, such as changing between an array type and an unconstrained domain over that array type, in return for making this code more future-proof. Noah Misch
2012-01-25Allow pg_basebackup from standby node with safety checking.Simon Riggs
Base backup follows recommended procedure, plus goes to great lengths to ensure that partial page writes are avoided. Jun Ishizuka and Fujii Masao, with minor modifications
2012-01-25Add pg_trigger_depth() functionAlvaro Herrera
This reports the depth level of triggers currently in execution, or zero if not called from inside a trigger. No catversion bump in this patch, but you have to initdb if you want access to the new function. Author: Kevin Grittner
2012-01-25Now that the shared library name can be adjusted in the library test,Bruce Momjian
have pg_upgrade allocate a maximum fixed size buffer for testing the library file name, rather than base the allocation on the library name. Backpatch to 9.1.
2012-01-25Improve plpython fix comment in pg_upgrade.Bruce Momjian
2012-01-25In pg_upgrade, when checking for the plpython library, we must check forBruce Momjian
"plpython2" when upgrading from pre-PG 9.1. Patch to head and 9.1. Per report from Peter.
2012-01-25Fix new SQL tablespace location function usage in pg_upgrade to properlyBruce Momjian
check cluster version numbers, and fix missing table alias.
2012-01-24Add new replication mode synchronous_commit = 'write'.Simon Riggs
Replication occurs only to memory on standby, not to disk, so provides additional performance if user wishes to reduce durability level slightly. Adds concept of multiple independent sync rep queues. Fujii Masao and Simon Riggs
2012-01-24Remove quotes around format_type_be() outputPeter Eisentraut
format_type_be() takes care of any needed quoting itself.
2012-01-24Suppress variable-clobbered-by-longjmp warning seen with older gcc versions.Tom Lane
2012-01-24Suppress possibly-uninitialized-variable warning seen with older gcc versions.Tom Lane
2012-01-24Reduce tab outdent of "error handling" GUC comments in postgresql.conf,Bruce Momjian
to match surrounding outdenting.
2012-01-24Adjustments to regression tests for security_barrier views.Robert Haas
Drop the role we create, so regression tests pass even when run more than once against the same cluster, a problem noted by Tom Lane and Jeff Janes. Also, rename the temporary role so that it starts with "regress_", to make it unlikely that we'll collide with an existing role name while running "make installcheck", per further gripe from Tom Lane.
2012-01-23Resolve timing issue with logging locks for Hot Standby.Simon Riggs
We log AccessExclusiveLocks for replay onto standby nodes, but because of timing issues on ProcArray it is possible to log a lock that is still held by a just committed transaction that is very soon to be removed. To avoid any timing issue we avoid applying locks made by transactions with InvalidXid. Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee
2012-01-23ALTER <thing> [IF EXISTS] ... allows silent DDL if required,Simon Riggs
e.g. ALTER FOREIGN TABLE IF EXISTS foo RENAME TO bar Pavel Stehule
2012-01-22Typo fixMagnus Hagander
Guillaume Lelarge
2012-01-21psql: Add support for tab completion of GRANT/REVOKE rolePeter Eisentraut
Previously, only GRANT/REVOKE privilege was supported. reviewed by Pavel Stehule
2012-01-20Check number of fields in IDENTIFY_SYSTEM responseMagnus Hagander
Jaime Casanova
2012-01-20Get rid of itemizedlist inside tableMagnus Hagander
This renders badly on the website, and in this particular case also doesn't actually add anything to the readability...
2012-01-20Further doc cleanups from the pg_stat_activity changesMagnus Hagander
Fujii Masao
generated by cgit v1.2.3 (git 2.39.1) at 2025-12-22 03:57:02 +0000