SQL/JSON: Always coerce JsonExpr result at runtime
authorAmit Langote <[email protected]>
Fri, 28 Jun 2024 12:58:13 +0000 (21:58 +0900)
committerAmit Langote <[email protected]>
Fri, 28 Jun 2024 12:58:13 +0000 (21:58 +0900)
commit716bd12d22c53d1943d41309f2dd061ec601dd5e
tree93a8030f6b2c690795c0d8bdb405206f476ee7b7
parentc2d93c3802b205d135d1ae1d7ac167d74e08a274
SQL/JSON: Always coerce JsonExpr result at runtime

Instead of looking up casts at parse time for converting the result
of JsonPath* query functions to the specified or the default
RETURNING type, always perform the conversion at runtime using either
the target type's input function or the function
json_populate_type().

There are two motivations for this change:

1. json_populate_type() coerces to types with typmod such that any
   string values that exceed length limit cause an error instead of
   silent truncation, which is necessary to be standard-conforming.

2. It was possible to end up with a cast expression that doesn't
   support soft handling of errors causing bugs in the of handling
   ON ERROR clause.

JsonExpr.coercion_expr which would store the cast expression is no
longer necessary, so remove.

Bump catversion because stored rules change because of the above
removal.

Reported-by: Alvaro Herrera <[email protected]>
Reviewed-by: Jian He <[email protected]>
Discussion: Discussion: https://postgr.es/m/202405271326.5a5rprki64aw%40alvherre.pgsql
15 files changed:
src/backend/executor/execExpr.c
src/backend/executor/execExprInterp.c
src/backend/jit/llvm/llvmjit_expr.c
src/backend/nodes/nodeFuncs.c
src/backend/parser/parse_expr.c
src/backend/utils/adt/jsonfuncs.c
src/include/catalog/catversion.h
src/include/executor/execExpr.h
src/include/nodes/execnodes.h
src/include/nodes/primnodes.h
src/include/utils/jsonfuncs.h
src/test/regress/expected/sqljson_jsontable.out
src/test/regress/expected/sqljson_queryfuncs.out
src/test/regress/sql/sqljson_jsontable.sql
src/test/regress/sql/sqljson_queryfuncs.sql