Fix race condition in stats.sql added in 5264add7847
authorAndres Freund <[email protected]>
Fri, 16 Sep 2022 17:07:12 +0000 (10:07 -0700)
committerAndres Freund <[email protected]>
Fri, 16 Sep 2022 18:28:20 +0000 (11:28 -0700)
commit885826f95d1c7803d3ff97bde64078b257543266
treebffd899032292212a2f6c4422123f7405fe5a7a2
parentb759bb6714f03e91071b8fe6d29c28a1f87ea4bb
Fix race condition in stats.sql added in 5264add7847

Very occasionally the stats test failed due to the number of sessions not
being updated yet. Likely this requires that there is contention on the
database's stats entry. Solve this by forcing pending stats to be flushed
before fetching the stats.

I verified that there are no other test failures after making
pgstat_report_stat() only flush stats when force = true.

Per message from Tom Lane and buildfarm member crake.

Discussion: https://postgr.es/m/3428246.1663271992@sss.pgh.pa.us
Backpatch: 15-, where 5264add7847 added the test
src/test/regress/expected/stats.out
src/test/regress/sql/stats.sql