Don't use double-quotes in #include's of system headers, redux.
authorTom Lane <[email protected]>
Sun, 27 Apr 2025 17:23:19 +0000 (13:23 -0400)
committerTom Lane <[email protected]>
Sun, 27 Apr 2025 17:23:19 +0000 (13:23 -0400)
commit94b84a60729e15ee071739c3aec7fdd781123aab
treedd7cfe54f977154b1ea5ab121d724b0bade11e23
parent2311f193ea7db23f68f5471ae2c35940fc0d4794
Don't use double-quotes in #include's of system headers, redux.

This cleans up some loose ends left by commit e8ca9ed1d.  I hadn't
looked closely enough at these places before, but now I have.

The use of double-quoted #includes for Perl headers in plperl_system.h
seems to be simply a mistake introduced in 6c944bf3c and faithfully
copied forward since then.  (I had thought possibly it was required
by some weird Windows build setup, but there's no evidence of that in
our history.)

The occurrences in SectionMemoryManager.h and SectionMemoryManager.cpp
evidently stem from those files' origin as LLVM code.  It's
understandable that LLVM would treat their own files as needing
double-quoted #includes; but they're still system headers to us.

I also applied the same check to *.c files, and found a few other
random incorrect usages in both directions.

Our ECPG headers and test files routinely use angle brackets to refer
to ECPG headers.  I left those usages alone, since it seems reasonable
for an ECPG user to regard those headers as system headers.
src/backend/jit/llvm/SectionMemoryManager.cpp
src/backend/storage/buffer/bufmgr.c
src/bin/initdb/initdb.c
src/bin/pg_dump/compress_gzip.c
src/bin/pg_verifybackup/pg_verifybackup.c
src/include/jit/SectionMemoryManager.h
src/pl/plperl/plperl_system.h