Avoid unhelpful internal error for incorrect recursive-WITH queries.
authorTom Lane <[email protected]>
Sun, 14 Jul 2024 17:49:46 +0000 (13:49 -0400)
committerTom Lane <[email protected]>
Sun, 14 Jul 2024 17:49:46 +0000 (13:49 -0400)
commitf96c2c72788cab3005c8bc6b4934b4928b34a529
tree6cd60539ca678ab88c840a3a4e796ddf90572b17
parentd5e6891502ca9e359aa5f5a381d904fe9d606338
Avoid unhelpful internal error for incorrect recursive-WITH queries.

checkWellFormedRecursion would issue "missing recursive reference"
if a WITH RECURSIVE query contained a single self-reference but
that self-reference was inside a top-level WITH, ORDER BY, LIMIT,
etc, rather than inside the second arm of the UNION as expected.
We already intended to throw more-on-point errors for such cases,
but those error checks must be done before examining the UNION arm
in order to have the desired results.  So this patch need only
move some code (and improve the comments).

Per bug #18536 from Alexander Lakhin.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/18536-0a342ec07901203e@postgresql.org
src/backend/parser/parse_cte.c
src/test/regress/expected/with.out
src/test/regress/sql/with.sql