From: Andrew Dunstan <andrew@dunslane.net>
Date: Mon, 8 Jul 2024 09:51:26 +0000 (-0400)
Subject: Force nodes for SSL tests to start in TCP mode
X-Git-Tag: REL_18_BETA1~2447
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=e4f4c5424cf9564b934ac6f632c6c90a2edddb77;p=postgresql.git

Force nodes for SSL tests to start in TCP mode

Currently they are started in unix socket mode in ost cases, and then
converted to run in TCP mode. This can result in port collisions, and
there is no virtue in startng in unix socket mode, so start as we will
be going on.

Discussion: https://postgr.es/m/d6ee8761-39d1-0033-1afb-d5a57ee056f2@gmail.com

Backpatch to all live branches (12 and up).
---

diff --git a/src/test/ssl/t/SSL/Server.pm b/src/test/ssl/t/SSL/Server.pm
index ca4c7b567b3..021eec74abf 100644
--- a/src/test/ssl/t/SSL/Server.pm
+++ b/src/test/ssl/t/SSL/Server.pm
@@ -70,6 +70,12 @@ use PostgreSQL::Test::Utils;
 use Test::More;
 use SSL::Backend::OpenSSL;
 
+# Force SSL tests nodes to begin in TCP mode. They won't work in Unix Socket
+# mode and this way they will find a port to run on in a more robust way.
+# Use an INIT block so it runs after the BEGIN block in Utils.pm.
+
+INIT { $PostgreSQL::Test::Utils::use_unix_sockets = 0; }
+
 =pod
 
 =head1 METHODS