summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-04Use lstrip instead of gsub which can match only onceNobuyoshi Nakada
2019-07-04Skip indented comment lines [Bug #15981]Nobuyoshi Nakada
2019-07-04Suppress uninitialized instance variable warningsNobuyoshi Nakada
2019-07-04Do not dispatch a nil token in ripperNobuyoshi Nakada
As a comment token includes the newline, so delayed newline token just follows it should not be dispatched. [Bug #11485] Co-Authored-By: Jeremy Evans <[email protected]>
2019-07-04Revert self-referencing finalizer warning [Feature #15974]Nobuyoshi Nakada
It has caused CI failures. * d0cd0866d82a58933e5dccd073c753c0c2ad4eb5 Disable GC during rb_objspace_reachable_object_p * 89cef1c56b3a0f9c5e6ccc22a5044477a4fd16c1 Version guard for [Feature #15974] * 796eeb6339952d92ae1b353d450c7883e589852d. Fix up [Feature #15974] * 928260c2a613bbdd4402c300e0bf86ae7562e52a. Warn in verbose mode on defining a finalizer that captures the object
2019-07-04* 2019-07-04git
2019-07-04* expand tabs.git
2019-07-04Disable GC during rb_objspace_reachable_object_pNobuyoshi Nakada
Try to fix CI breakage by [Feature #15974].
2019-07-03Renamed to rb_objspace_reachable_object_pNobuyoshi Nakada
2019-07-03Check code_block_open for whether code continuesaycabta
2019-07-03Ensure that GC is disabled during compactionAaron Patterson
Various things can cause GC to occur when compaction is running, for example resizing the object identity map: ``` frame #24: 0x000000010c784a10 ruby`gc_grey [inlined] push_mark_stack(stack=<unavailable>, data=<unavailable>) at gc.c:4311:42 frame #25: 0x000000010c7849ff ruby`gc_grey(objspace=0x00007fc56c804400, obj=140485906037400) at gc.c:4907 frame #26: 0x000000010c78f881 ruby`gc_start at gc.c:6464:8 frame #27: 0x000000010c78f5d1 ruby`gc_start [inlined] gc_marks_start(objspace=0x00007fc56c804400, full_mark=<unavailable>) at gc.c:6009 frame #28: 0x000000010c78f3c0 ruby`gc_start at gc.c:6291 frame #29: 0x000000010c78f399 ruby`gc_start(objspace=0x00007fc56c804400, reason=<unavailable>) at gc.c:7104 frame #30: 0x000000010c78930c ruby`objspace_xmalloc0 [inlined] objspace_malloc_fixup(objspace=<unavailable>, mem=0x000000011372a000, size=<unavailable>) at gc.c:9665:5 frame #31: 0x000000010c7892f5 ruby`objspace_xmalloc0(objspace=0x00007fc56c804400, size=12582912) at gc.c:9707 frame #32: 0x000000010c89bc13 ruby`st_init_table_with_size(type=<unavailable>, size=<unavailable>) at st.c:605:39 frame #33: 0x000000010c89c5e2 ruby`rebuild_table_if_necessary [inlined] rebuild_table(tab=0x00007fc56c40b250) at st.c:780:19 frame #34: 0x000000010c89c5ac ruby`rebuild_table_if_necessary(tab=0x00007fc56c40b250) at st.c:1142 frame #35: 0x000000010c89c379 ruby`st_insert(tab=0x00007fc56c40b250, key=140486132605040, value=140485922918920) at st.c:1161:5 frame #36: 0x000000010c794a16 ruby`gc_compact_heap [inlined] gc_move(objspace=0x00007fc56c804400, scan=<unavailable>, free=<unavailable>, moved_list=140485922918960) at gc.c:7441:9 frame #37: 0x000000010c794917 ruby`gc_compact_heap(objspace=0x00007fc56c804400, comparator=<unavailable>) at gc.c:7695 frame #38: 0x000000010c79410d ruby`gc_compact [inlined] gc_compact_after_gc(objspace=0x00007fc56c804400, use_toward_empty=1, use_double_pages=<unavailable>, use_verifier=1) at gc.c:0:22 ``` We *definitely* need the heap to be in a consistent state during compaction, so this commit sets the current state to "during_gc" so that nothing will trigger a GC until the heap finishes compacting. This fixes the bug we saw when running the tests for https://github.com/ruby/ruby/pull/2264
2019-07-03Try to avoid `not delagated` errorKazuhiro NISHIYAMA
``` .../ruby/lib/delegate.rb:405:in `__getobj__': not delegated (ArgumentError) ``` https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian9/ruby-master/log/20190703T063006Z.fail.html.gz
2019-07-03Version guard for [Feature #15974]Nobuyoshi Nakada
2019-07-03Fix order of testsNobuyoshi Nakada
`check` includes `test-testframework`, `test-short` and its preceeding tests, but `test-all` does not.
2019-07-03Just disable inlining with local varaible for nowTakashi Kokubun
This partially reverts commit 712a66b0741605f5b2db670a292b9bb352f8a716. The previous fix made CI strange like: http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/2124178 Let me just downgrade the behavior for now and deal with it later. [Bug #15971]
2019-07-03Debugging failures on x86_64-darwin17 of travis-ciKazuhiro NISHIYAMA
https://travis-ci.org/ruby/ruby/jobs/553346285
2019-07-03* expand tabs.git
2019-07-03Fix up [Feature #15974]Nobuyoshi Nakada
* Fixed warning condition * Fixed function signature * Use ident hash
2019-07-03Warn in verbose mode on defining a finalizer that captures the objectChris Seaton
[Feature #15974] Closes: https://github.com/ruby/ruby/pull/2264
2019-07-03Revert expansion of test-allNobuyoshi Nakada
2019-07-03Revert "Avoid corrupting VM stack on inlined setlocal"Koichi Sasada
This reverts commit ea30dd702512ff9df34fe8c71c825f8f901bf5b1. because it fails when VM_CHECK_MODE=1.
2019-07-03* expand tabs.git
2019-07-03Use rb_ident_hash_new instead of rb_hash_new_compare_by_idNobuyoshi Nakada
The latter is same as the former, removed the duplicate function.
2019-07-02Check that String#scrub block does not modify receiverJeremy Evans
Similar to the check used for String#gsub. Can fix possible segfault. Fixes [Bug #15941]
2019-07-02Make String#-@ not freeze receiver if called on unfrozen subclass instanceJeremy Evans
rb_fstring behavior in this case is to freeze the receiver. I'm not sure if that should be changed, so this takes the conservative approach of duping the receiver in String#-@ before passing to rb_fstring. Fixes [Bug #15926]
2019-07-02Remove Changelog section from doc/contributing.rdoc [ci skip]Jeremy Evans
Replace it with a section on commit message formatting. Also, move the section on rebasing to the bottom, since that only applies to committers and not most contributors. Fixes [Bug #14886]
2019-07-03* 2019-07-03git
2019-07-02Implement Array#minmaxJeremy Evans
Array#minmax was previous not implemented, so calling #minmax on array was actually calling Enumerable#minmax. This is a simple implementation of #minmax by just calling rb_ary_min and rb_ary_max, which improves performance significantly. Fixes [Bug #15929]
2019-07-02Fix timezone issue for logger period's testsYusuke Endoh
This is a retry of 181b966e7553ac53d034266a7cdc18664d080814. "Revert "Add a missing tests for Logger::Period module"" is also reverted.
2019-07-02Revert "Add a missing tests for Logger::Period module"Koichi Sasada
This reverts commit 181b966e7553ac53d034266a7cdc18664d080814.
2019-07-02Avoid corrupting VM stack on inlined setlocalTakashi Kokubun
setlocal relies on cfp->ep, and frame-omitted method inlining introduced in Ruby 2.7 kept it wrong. This change might slow down frame-omitted method inlining for cfp->ep manipulation, and it obviously complicates the implementaion more. By introducing an optimization that changes Ruby's local variable to C local variable, we could optimize it and simplify the cfp->ep manipulation later. [Bug #15971]
2019-07-02Add a missing tests for Logger::Period moduleAnton Davydov
Closes: https://github.com/ruby/ruby/pull/2266
2019-07-02The behavior of statx(2) depends on the filesystemNobuyoshi Nakada
birthtime may not be supported on some filesystems, and NotImplementedError can be raised. [Bug #15972]
2019-07-02Adjust memory_status.rb under the tool directory.Hiroshi SHIBATA
2019-07-02Fix test-all substitutionNobuyoshi Nakada
2019-07-02Clean up temporary expired cert fileNobuyoshi Nakada
2019-07-02Clean up temporary directory for raccNobuyoshi Nakada
2019-07-02${} does not work with nmake.exeNobuyoshi Nakada
2019-07-02Use GitHub ruby.git for make-snapshotTakashi Kokubun
Previously @hsbt disabled https git clone from git.ruby-lang.org. Using git.ruby-lang.org for non-commit purposes is discouraged. GitHub mirror is actually recommended because it's reliable than single-hosted git.ruby-lang.org, the mirror is almost always well-maintained, and its latency is very small (usually about 10s). So we should just use GitHub here. [Bug #15969]
2019-07-02Adjust jit_support file path.Hiroshi SHIBATA
2019-07-02Removed test-almost from TEST_TARGETSNobuyoshi Nakada
2019-07-02Now test-almost equals to test-allNobuyoshi Nakada
2019-07-02Substitute autoconf variables by prereq.statusNobuyoshi Nakada
2019-07-02with_different_ofs.rb has been moved tooNobuyoshi Nakada
2019-07-02Adjust minitest file pathNobuyoshi Nakada
2019-07-02Prefer master rather than trunk in doc/contributing.rdoc [ci skip]Kazuhiro NISHIYAMA
2019-07-02[DOC] Add LibreSSL [ci skip]Kazuhiro NISHIYAMA
2019-07-02Renamed to get rid of name clashNobuyoshi Nakada
2019-07-02Adjust minitest file pathNobuyoshi Nakada
2019-07-02Removed needless exclude option related testframework.Hiroshi SHIBATA
They are moved under the tool directory now.