From cc27cd26d728d285aed728e730994d31f5ac1241 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?= Date: Tue, 16 Jun 2020 13:02:03 +0900 Subject: rand_range: do not goto into a branch I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor. --- random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'random.c') diff --git a/random.c b/random.c index 708f5c4756..8a59d1c0f9 100644 --- a/random.c +++ b/random.c @@ -1169,8 +1169,8 @@ rand_range(VALUE obj, rb_random_t* rnd, VALUE range) long max; vmax = v; v = Qnil; + fixnum: if (FIXNUM_P(vmax)) { - fixnum: if ((max = FIX2LONG(vmax) - excl) >= 0) { unsigned long r = random_ulong_limited(obj, rnd, (unsigned long)max); v = ULONG2NUM(r); -- cgit v1.2.3