From 680e06002666883537c05f796c31c6eacd6b4858 Mon Sep 17 00:00:00 2001
From: Matt Valentine-House <matt@eightbitraptor.com>
Date: Wed, 20 Nov 2024 16:20:38 +0000
Subject: [prism/compiler] end_cursor should never be NULL

This fixes a failed assertion reported to SimpleCov

https://github.com/simplecov-ruby/simplecov/issues/1113

This can be repro'd as follows:

1. Create a file `test.rb` containing the following code

```
@foo&.(@bar)
```

2. require it with branch coverage enabled

```
ruby -rcoverage -e "Coverage.start(branches: true); require_relative 'test.rb'"
```

The assertion is failing because the Prism compiler is incorrectly
detecting the start and end cursor position of the call site for the
implicit call .()

This patch replicates the parse.y behaviour of setting the default
end_cursor to be the final closing location of the call node.

This behaviour can be verified against `parse.y` by modifying the test
command as follows:

```
ruby --parser=parse.y -rcoverage -e "Coverage.start(branches: true); require_relative 'test.rb'"
```

[Bug #20866]
---
 test/coverage/test_coverage.rb | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'test/coverage/test_coverage.rb')

diff --git a/test/coverage/test_coverage.rb b/test/coverage/test_coverage.rb
index 814b7e088b..9db1f8f253 100644
--- a/test/coverage/test_coverage.rb
+++ b/test/coverage/test_coverage.rb
@@ -463,6 +463,8 @@ class TestCoverage < Test::Unit::TestCase
         [:"&.", 3, 7, 0, 7,  6] => {[:then,  4, 7, 0, 7,  6]=>0, [:else,  5, 7, 0, 7,  6]=>1},
         [:"&.", 6, 8, 0, 8, 10] => {[:then,  7, 8, 0, 8, 10]=>1, [:else,  8, 8, 0, 8, 10]=>0},
         [:"&.", 9, 9, 0, 9, 10] => {[:then, 10, 9, 0, 9, 10]=>0, [:else, 11, 9, 0, 9, 10]=>1},
+        [:"&.", 12, 10, 0, 10, 6] => {[:then, 13, 10, 0, 10, 6] => 0, [:else, 14, 10, 0, 10, 6] => 1},
+        [:"&.", 15, 11, 0, 11, 5] => {[:then, 16, 11, 0, 11, 5] => 0, [:else, 17, 11, 0, 11, 5] => 1},
       }
     }
     assert_coverage(<<~"end;", { branches: true }, result)
@@ -475,6 +477,8 @@ class TestCoverage < Test::Unit::TestCase
       b&.foo
       c&.foo = 1
       d&.foo = 1
+      d&.(b)
+      d&.()
     end;
   end
 
-- 
cgit v1.2.3

773dc30518'>refs</a><a class='active' href='/https/git.ruby-lang.org/ruby.git/log/lib/shell/filter.rb'>log</a><a href='/https/git.ruby-lang.org/ruby.git/tree/lib/shell/filter.rb?id=bebe8d13f8e14dffa9d1828f6e9805773dc30518'>tree</a><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=bebe8d13f8e14dffa9d1828f6e9805773dc30518'>commit</a><a href='/https/git.ruby-lang.org/ruby.git/diff/lib/shell/filter.rb?id=bebe8d13f8e14dffa9d1828f6e9805773dc30518'>diff</a></td><td class='form'><form class='right' method='get' action='/ruby.git/log/lib/shell/filter.rb'>
<input type='hidden' name='id' value='bebe8d13f8e14dffa9d1828f6e9805773dc30518'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/https/git.ruby-lang.org/ruby.git/log/?id=bebe8d13f8e14dffa9d1828f6e9805773dc30518'>root</a>/<a href='/https/git.ruby-lang.org/ruby.git/log/lib?id=bebe8d13f8e14dffa9d1828f6e9805773dc30518'>lib</a>/<a href='/https/git.ruby-lang.org/ruby.git/log/lib/shell?id=bebe8d13f8e14dffa9d1828f6e9805773dc30518'>shell</a>/<a href='/https/git.ruby-lang.org/ruby.git/log/lib/shell/filter.rb?id=bebe8d13f8e14dffa9d1828f6e9805773dc30518'>filter.rb</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/https/git.ruby-lang.org/ruby.git/log/lib/shell/filter.rb?id=bebe8d13f8e14dffa9d1828f6e9805773dc30518&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2017-03-29 11:49:39 +0000'>2017-03-29</span></td><td><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=e294fbaf5fd48fa1f32a0e8709462363e62f200e'>Fix two typos</a></td><td>mame</td></tr>
<tr><td><span title='2016-11-29 16:06:54 +0000'>2016-11-29</span></td><td><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=716610ae565caed8df725dd26ffbc2000b673fcd'>get rid of ambiguous parentheses warnings</a></td><td>nobu</td></tr>
<tr><td><span title='2015-12-16 05:07:31 +0000'>2015-12-16</span></td><td><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=3e92b635fb5422207b7bbdc924e292e51e21f040'>Add frozen_string_literal: false for all files</a></td><td>naruse</td></tr>
<tr><td><span title='2013-12-15 02:09:41 +0000'>2013-12-15</span></td><td><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=82eef27f46a56f033c61e2724ababb0a7997b465'>* lib/shell/filter.rb:  [DOC] Fix typo</a></td><td>a_matsuda</td></tr>
<tr><td><span title='2012-12-05 02:55:07 +0000'>2012-12-05</span></td><td><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=342d2f2aa6037bd126c2247c6c6b9bf97f8c42bd'>* doc/shell.rd, doc/shell.rd.ja: Removed stale doc files</a></td><td>zzak</td></tr>
<tr><td><span title='2011-05-19 00:07:25 +0000'>2011-05-19</span></td><td><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=d371e3583e3b1e0692f92343017b62d2628190ff'>* lib: revert r31635-r31638 and untabify with expand(1).</a></td><td>nobu</td></tr>
<tr><td><span title='2011-05-18 21:19:18 +0000'>2011-05-18</span></td><td><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=7bbf2f308580f468802cd7d32c94fce1b9f1779e'>	* lib:  Convert tabs to spaces for ruby files per</a></td><td>drbrain</td></tr>
<tr><td><span title='2009-03-06 03:56:38 +0000'>2009-03-06</span></td><td><a href='/https/git.ruby-lang.org/ruby.git/commit/lib/shell/filter.rb?id=287a34ae0dfc23e4158f67cb7783d239f202c368'>* {ext,lib,test}/**/*.rb: removed trailing spaces.</a></td><td>nobu</td></tr>