From 0eeb116923171e73876d286e9573cb21cae057ae Mon Sep 17 00:00:00 2001 From: kosaki Date: Sun, 10 Mar 2013 04:00:00 +0000 Subject: * thread_pthread.c (ubf_select): add to small comments why we need to call rb_thread_wakeup_timer_thread(). git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39684 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- thread_pthread.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'thread_pthread.c') diff --git a/thread_pthread.c b/thread_pthread.c index c986f223c0..381647a7a7 100644 --- a/thread_pthread.c +++ b/thread_pthread.c @@ -1098,8 +1098,16 @@ ubf_select(void *ptr) { rb_thread_t *th = (rb_thread_t *)ptr; add_signal_thread_list(th); + + /* + * ubf_select_each() doesn't guarantee to wake up the target thread. + * Therefore, we need to activate timer thread when called from + * Thread#kill etc. + * In the other hands, we shouldn't call rb_thread_wakeup_timer_thread() + * if running on timer thread because it may make endless wakeups. + */ if (pthread_self() != timer_thread_id) - rb_thread_wakeup_timer_thread(); /* activate timer thread */ + rb_thread_wakeup_timer_thread(); ubf_select_each(th); } -- cgit v1.2.3