Skip to content

Add a Copy button the Snippets tab #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 2 commits into from
Oct 11, 2018
Merged

Add a Copy button the Snippets tab #2445

Rokt33r merged 2 commits into from
Oct 11, 2018

Conversation

@jacobherrington
Copy link
Contributor

@jacobherrington jacobherrington commented Sep 30, 2018

This adds a button to copy snippets.

Solves #2108

@IssueHuntBot IssueHuntBot mentioned this pull request Sep 30, 2018
Closed
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 2, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Oct 2, 2018

Can you show some message when the snippet is copied? For example:
https://github.com/BoostIO/Boostnote/blob/2ccd00a378cdc1511ac17e4b40470976d1a1e1a4/browser/components/MarkdownPreview.js#L694-L697

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 2, 2018
@jacobherrington
Copy link
Contributor Author

jacobherrington commented Oct 2, 2018

It adds a little bit of code duplication, but changes made!

@ZeroX-DG ZeroX-DG self-assigned this Oct 2, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Oct 2, 2018

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Oct 2, 2018
@Rokt33r Rokt33r merged commit 1821a5c into BoostIO:master Oct 11, 2018
@Rokt33r Rokt33r added next release (v0.11.10) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees

@ZeroX-DG ZeroX-DG

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobherrington @ZeroX-DG @Rokt33r