Skip to content

Multiple minor changes at the preferences tabs#2889

Merged
Rokt33r merged 5 commits intoBoostIO:masterfrom
dredav:preferences
Apr 28, 2019
Merged

Multiple minor changes at the preferences tabs#2889
Rokt33r merged 5 commits intoBoostIO:masterfrom
dredav:preferences

Conversation

@dredav
Copy link
Contributor

@dredav dredav commented Feb 17, 2019

Issue fixed

  • This pull request will adjust all first headlines in all preferences tabs.
  • At the Crowdfunding tab, the paragraph headlines are now real headlines (not only text with ###)
  • The snippet editor has now the right width of 100% (before 103%)

Type of changes

  • 🔵 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔵 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 18, 2019
ZeroX-DG
ZeroX-DG reviewed Feb 20, 2019
View reviewed changes
browser/main/modals/PreferencesModal/SnippetTab.styl Outdated

.snippet-detail
width 70%
width calc(100% - 33%)
Copy link
Member

@ZeroX-DG ZeroX-DG Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you just replace the calc with 67%?

Copy link
Contributor Author

@dredav dredav Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZeroX-DG You're right. I've replaced it with the static value.

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 20, 2019
ZeroX-DG
ZeroX-DG requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Can you fix the header colour?

@dredav
Copy link
Contributor Author

dredav commented Mar 1, 2019

image
Can you fix the header colour?

@ZeroX-DG Sure.
I've changed the color of the Boostnote Headline to the same color for the headlines. I've also found some missing styles in other themes for headlines and adjust the "Save" Button at the About-Tab.

ZeroX-DG
ZeroX-DG approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Mar 7, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Mar 20, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Apr 28, 2019
@Rokt33r Rokt33r merged commit 3c9d614 into BoostIO:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.11.16

Development

Successfully merging this pull request may close these issues.

3 participants

@dredav @ZeroX-DG @Rokt33r