Skip to content

[Feature] Add support for plantUML mindmap, wbs, gantt#3010

Closed
MSSandroid wants to merge 4 commits intoBoostIO:masterfrom
MSSandroid:plantumlMindMap
Closed

[Feature] Add support for plantUML mindmap, wbs, gantt#3010
MSSandroid wants to merge 4 commits intoBoostIO:masterfrom
MSSandroid:plantumlMindMap

Conversation

@MSSandroid
Copy link
Contributor

Description

I have added supprt for mindmap, wbs and gantt charts in plantuml. I just copied the part for the part for Ditaa chart and change the @ indicators and switched to svg output.
I havent added any tests, since I am not shure how. Test and lint have same output as current master

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ✅ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ✅ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ✅ All existing tests have been passed
  • ✅ I have attached a screenshot/video to visualize my change if possible

Screenshot_20190518_145129

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label May 19, 2019
@Komalis
Copy link

Komalis commented Jun 18, 2019

What is taking so much time to review?

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jun 27, 2019

Hi, sorry for the late review. @MSSandroid Can you add a simple snapshot test? Just add the test to this file and delete the snap file in the same directory and run yarn test to test it. Apart from that everything works fine.
https://github.com/BoostIO/Boostnote/blob/master/tests/lib/snapshots/markdown-test.js.md

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 27, 2019
@MSSandroid
Copy link
Contributor Author

I have now added separate tests for the different diagram types. Sorry for the delay.

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Sep 5, 2019

@MSSandroid Can you fix the conflict before I approve your code?

@MSSandroid
Copy link
Contributor Author

I falsely deleted the branch in my fork.... Reopened a copy in pull request # 3249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants