[Feature] Add support for plantUML mindmap, wbs, gantt#3010
Closed
MSSandroid wants to merge 4 commits intoBoostIO:masterfrom
Closed
[Feature] Add support for plantUML mindmap, wbs, gantt#3010MSSandroid wants to merge 4 commits intoBoostIO:masterfrom
MSSandroid wants to merge 4 commits intoBoostIO:masterfrom
Conversation
|
What is taking so much time to review? |
Member
|
Hi, sorry for the late review. @MSSandroid Can you add a simple snapshot test? Just add the test to this file and delete the snap file in the same directory and run |
Contributor
Author
|
I have now added separate tests for the different diagram types. Sorry for the delay. |
Member
|
@MSSandroid Can you fix the conflict before I approve your code? |
Contributor
Author
|
I falsely deleted the branch in my fork.... Reopened a copy in pull request # 3249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added supprt for mindmap, wbs and gantt charts in plantuml. I just copied the part for the part for Ditaa chart and change the @ indicators and switched to svg output.
I havent added any tests, since I am not shure how. Test and lint have same output as current master
Issue fixed
Type of changes
Checklist: