fix: #288 Fixed Snippet tabs overwriting other tabs when closed

[redcom]

This should fix the issue for you.

[asmsuechan]

@redcom Thanks so much for fixing! It almost behaves correct, but I find an error when I delete the rightmost tab.

SnippetNoteDetail.js?64bd:267 Uncaught TypeError: Cannot read property 'reload' of undefined

[redcom]

This is true. I'll have a look later today.

[asmsuechan]

Thank you!

[redcom]

Coll. I submitted a fix. It should be good now. Can you tell me what do you use to produce those animated gifs that show the issue?

[asmsuechan]

@redcom This works fine. Thank you! I use Gyazo to capture my screen 😄 It can take at most 6 sec.

BTW, you don't need to combine your commits into one. Because it's trouble when I rebase your branch.

[asmsuechan]

Could you change let to const?

[redcom]

sure

[redcom]

sure

[asmsuechan]

I assume this is more readable.

  deleteSnippetByIndex (index) {
    const snippets = this.state.note.snippets.slice()
    snippets.splice(index, 1)
    const note = Object.assign({}, this.state.note, {snippets})
    const snippetIndex = this.state.snippetIndex >= snippets.length
      ? snippets.length - 1
      : this.state.snippetIndex
    this.setState({ note, snippetIndex }, () => {
      this.save()
      this.refs['code-' + this.state.snippetIndex].reload()
    })
  }

[redcom]

It looks like so.

[asmsuechan]

Cool! LGTM

[redcom]

Thanks for accepting my commiting