Fix issue: reconnection only happends for 1 time after connection drops#136
Merged
joeybaker merged 1 commit intoEventSource:masterfrom Jul 7, 2020
Merged
Fix issue: reconnection only happends for 1 time after connection drops#136joeybaker merged 1 commit intoEventSource:masterfrom
joeybaker merged 1 commit intoEventSource:masterfrom
Conversation
aslakhellesoy
approved these changes
May 21, 2020
Contributor
aslakhellesoy
left a comment
There was a problem hiding this comment.
Looks good to me! 🙏
joeybaker
reviewed
May 23, 2020
Since the PR EventSource#125 fixed duplicate connections after reconnection by using a `connectionInProgress` lock to avoid function `connect()` be called duplicately. But it forgot to release the `connectionInProgress` lock when request error happends, in that case, our client can only retry for 1 time and never get the lock again. So it's needed to release the `connectionInProgress` lock when error happends. Signed-off-by: icy_fish <keith519@qq.com>
|
Hi, any idea when this will be merged and published? Is there any way we could help? Thanks! |
Contributor
|
Hi! I'm happy to merge, but I don't have npm publish access so will have to wait for someone who does |
Contributor
|
@joeybaker can you update History.md please? Then I’ll make a release. |
|
Can we get this released please? the current release on npm is still broken. |
joeybaker
added a commit
that referenced
this pull request
Mar 16, 2021
Contributor
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the PR #125 fixed duplicate connections after reconnection by using a
connectionInProgresslock to avoid functionconnect()be called duplicately.But it forgot to release the
connectionInProgresslock when request error happends, in that case, our client can only retry for 1 time and never get the lock again.So it's needed to release the
connectionInProgresslock when error happends.