Skip to content

Conversation

@halio-g
Copy link
Contributor

@halio-g halio-g commented Oct 31, 2023

  • Added validation to skip pushdown for Array type columns.
  • Added unit test for Datatype Binary and Decimal.

Copy link
Contributor

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @halio-g! Just one comment but also did we remember to return the col_type in our schema information query?

@halio-g
Copy link
Contributor Author

halio-g commented Oct 31, 2023

Thanks @halio-g! Just one comment but also did we remember to return the col_type in our schema information query?

We only store the json and jsonb in the col_type, so we don't need to modify the schema information query. We need the metadata when converting the Spark SQL to GoogleSql.

@halio-g halio-g merged commit d1ae848 into main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants