Skip to content

Tune performance #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halio-g merged 3 commits into from
Nov 8, 2023
Merged

Tune performance #120

halio-g merged 3 commits into from
Nov 8, 2023

Conversation

@halio-g
Copy link
Contributor

@halio-g halio-g commented Nov 8, 2023

  • Made the columns to be pruned before sending to Cloud Spanner.
  • Made the filter order passed to Cloud Spanner the same as input.

odeke-em
odeke-em approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @halio-g!

@halio-g
Copy link
Contributor Author

halio-g commented Nov 8, 2023

Thanks for the review @odeke-em . :)

@halio-g halio-g merged commit 2e8dce2 into main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@odeke-em odeke-em odeke-em approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@halio-g @odeke-em