feat: Add Windows support and interactive automation script #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides two major enhancements: 1. Makes the core `pidcat.py` script fully cross-platform. 2. Adds a new interactive batch script for convenient use on Windows. -------------------------------------------------- Python Script Enhancements (`pidcat.py`): - Replaced Unix-only `fcntl` for terminal width detection with the cross-platform `shutil.get_terminal_size()`. - Integrated the `colorama` library to correctly render ANSI color codes on the Windows Command Prompt. - Added a startup check to ensure an `adb` device is connected. - Prevents silent hangs by providing feedback when a specified package is not running. - Catches KeyboardInterrupt (Ctrl+C) to provide a clean exit message. New Windows Automation Script (`start_pidcat.bat`): - Introduces `start_pidcat.bat`, a helper script for Windows users to automate logging sessions. - The script interactively prompts for a package name and has a configurable default, making it flexible for daily use. - It automatically invokes `pidcat.py` with the `-c` flag to clear the device log buffer, ensuring a clean start for each session. - NOTE: Users need to edit the hardcoded path to `pidcat.py` within this batch file to match their local setup.
1. Makes the core `pidcat.py` script fully cross-platform. 2. Adds a new interactive batch script for convenient use on Windows. -------------------------------------------------- Python Script Enhancements (`pidcat.py`): - Replaced Unix-only `fcntl` for terminal width detection with the cross-platform `shutil.get_terminal_size()`. - Integrated the `colorama` library to correctly render ANSI color codes on the Windows Command Prompt. - Added a startup check to ensure an `adb` device is connected. - Prevents silent hangs by providing feedback when a specified package is not running. - Catches KeyboardInterrupt (Ctrl+C) to provide a clean exit message. New Windows Automation Script (`start_pidcat.bat`): - Introduces `start_pidcat.bat`, a helper script for Windows users to automate logging sessions. - The script interactively prompts for a package name and has a configurable default, making it flexible for daily use. - It automatically invokes `pidcat.py` with the `-c` flag to clear the device log buffer, ensuring a clean start for each session. - NOTE: Users need to edit the hardcoded path to `pidcat.py` within this batch file to match their local setup.
- Added interactive device selection for multiple connected ADB devices. - Improved subprocess output handling and error management for ADB commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides two major enhancements:
pidcat.pyscript fully cross-platform.Python Script Enhancements (
pidcat.py):fcntlfor terminal width detection with thecross-platform
shutil.get_terminal_size().coloramalibrary to correctly render ANSI colorcodes on the Windows Command Prompt.
adbdevice is connected.New Windows Automation Script (
start_pidcat.bat):start_pidcat.bat, a helper script for Windows usersto automate logging sessions.
configurable default, making it flexible for daily use.
pidcat.pywith the-cflag to clear thedevice log buffer, ensuring a clean start for each session.
pidcat.pywithinthis batch file to match their local setup.