fix(fastapi): use correct impl & package vars on custom user values #20970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)Changes
This fixes an error when the user supplys custom values for
fastapiImplementationPackageandpackageNamein thepython-fastapigenerator.Currently when the user sets these, the
implPackagewill be generated on the wrong path (using the default package name) and starting theuvicornpython server would fail, due to wrong imports.The behavior can be tested with these commands run from the projects root dir:
Please compare the
src/<moduleName>andsrc/<moduleName>/implnames.NOTE: There are existing tests, unfortunately these contained the same error as in the source-code. The source and test have been adapted and the handling of
implPackagenow aligns more to the handling of other attributes likepackageName.cc: @cbornet @tomplus @krjakbrjak @fa0311 @multani @krjakbrjak