Feat: Implement Discovery support #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d79d51 to
49e1679
Compare
a505d71 to
227fd15
Compare
src/OpenConext/EngineBlock/Metadata/Factory/Decorator/AbstractIdentityProvider.php
Show resolved
Hide resolved
src/OpenConext/EngineBlockBundle/Twig/Extensions/Extension/Wayf.php
Outdated
Show resolved
Hide resolved
965cf31 to
702c1aa
Compare
Prior to this change, there were cases where it wasn't clear which IdP end users should use. In these scenario's the users needed an IdP which was not recognisable for them. This change adds support for discovery IdP entries. Which are additional names / ways of finding an IdP in the WAYF. These can be configured in Manage. A discovery requires at least an english name, but can also include keywords or a custom logo, which is used on the consent page as well. Resolves #1338
702c1aa to
470e402
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, there were cases where it wasn't clear which
IdP end users should use. In these scenario's the users needed an IdP
which was not recognisable for them.
This change adds support for discovery IdP entries.
Which are additional names / ways of finding an IdP in the WAYF.
These can be configured in Manage.
A discovery requires at least an english name, but can also include
keywords or a custom logo, which is used on the consent page as well.
Resolves #1338