Fixed text color on tabs in MacOS #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Do you know why this fixes the issue? I would rather not make all of the text html if there is a more understandable way to fix this issue. |
Contributor
Author
|
I believe it is because HTML defaults the foreground color to black. |
Contributor
Author
|
I made it use setForeground rather than HTML. |
TheThirdOne
added a commit
that referenced
this pull request
Sep 25, 2021
Owner
|
Sorry for taking a while to get this in. I had a few modifications I wanted to make, but didn't have the time to get to it until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the value of the text to be surrounded by HTML that changes nothing about the style, but makes the coloring correct.
Example:
"Run I/O"becomes"<html><center><p>Run I/O</p></center></html>"Also added checks for .DS_Store files generated by the MacOS file system in the .gitignore.
I also added checks for build and rars.jar, which are produced by the build, but just in you accidentally git add them as I did.
Closes #128