Skip to content

new icon: windows11 (original, plain)#76

Closed
Panquesito7 wants to merge 4 commits intoThomas-Boi:developfrom
devicons:panquesito7/new_icon/windows11
Closed

new icon: windows11 (original, plain)#76
Panquesito7 wants to merge 4 commits intoThomas-Boi:developfrom
devicons:panquesito7/new_icon/windows11

Conversation

@Panquesito7
Copy link

New icon section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • The PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date


New feature section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format New Feature: a brief description of feature

This PR adds/fixes

Notes

@Panquesito7
Copy link
Author

@Thomas-Boi.

@Thomas-Boi Thomas-Boi added the bot:peek Use this label so GitHub Actions bot can peek at the new icons that label Aug 29, 2021
@github-actions
Copy link

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: 'Panquesito7/new icon/windows11'

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi changed the title Panquesito7/new icon/windows11 new icon: windows11 (original, plain) Aug 29, 2021
@Thomas-Boi Thomas-Boi added bot:peek Use this label so GitHub Actions bot can peek at the new icons that and removed bot:peek Use this label so GitHub Actions bot can peek at the new icons that labels Aug 29, 2021
@github-actions
Copy link

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Message: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://remote/content/marionette/capture.js :: capture.canvas :: line 141"  data: no]

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi added bot:peek Use this label so GitHub Actions bot can peek at the new icons that and removed bot:peek Use this label so GitHub Actions bot can peek at the new icons that labels Aug 29, 2021
@github-actions
Copy link

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Message: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://remote/content/marionette/capture.js :: capture.canvas :: line 141"  data: no]

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi
Copy link
Owner

Seems like the issue still persist and the problem is not with Selenium. After doing some research, there was a similar issue before with taking screenshot of canvases in Firefox. However, this apparently has been fixed.

I'll test your icons locally and try to resolve it. Hopefully, we can get it in for the next release

@Thomas-Boi
Copy link
Owner

Seems like it wasn't as fixed as I thought: https://bugzilla.mozilla.org/show_bug.cgi?id=1471265

@Thomas-Boi
Copy link
Owner

I've narrowed the issue down:

  • Seems like Selenium can't take pictures of elements that aren't visible in the page
  • However, the element that I selected IS visible. I don't know why it isn't the case here. The only change is a warning about multi-colored font.

I'm investigating this further. Hopefully I'll figure it out by tonight

@Thomas-Boi
Copy link
Owner

So I found the issue:

image

The code was failing here since it can't take pictures of the greyed out element. This is because the element is not visible. This didn't happen when I first developed the script. I'll now check for non-visible elements before taking screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Use this label so GitHub Actions bot can peek at the new icons that

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants