Fix clabel #1323
Fix clabel #1323
Conversation
dopplershift
left a comment
There was a problem hiding this comment.
Changes seem fine, though I'm calling them a work-around rather than a fix. Need to look at the clabel thing and decide if it's matplotlib or CartoPy.
Also, while I'd say the new image for test_latlon is an improvement, I'm deeply disturbed that changing when we set the extent even introduces that change, so that's another upstream issue.
|
I can appreciate calling this a work around. From my explorations I'm thinking more likely Cartopy than Matplotlib, but not totally convinced. This seems similar to issues that I had at one point with plotting skewTs and if you set the limits in a certain way it would affect the final output. Blanking on the exact details of the skewT issue at this point, but I do remember having issues with when the xlim and slim were set in prior lifetimes. |
Description Of Changes
This PR fixes #1322 and re-orders the draw procedure in the declarative syntax. It puts setting the extent before drawing the contours/colorfills/etc. in oder to allow sane contour labelling to happen. Additionally, it modifies the default inline spacing of the contour labels from 2 to 10 as a result of the sane behavior. Finally, three test images were updated as with the behavior change came a change in the output from those tests.
See issue #1322 for a more complete description of the problem that this PR is fixing.
Checklist