uglifyjs license fix, grunt support, bower support #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dist version of eventsource - minified
Owner
There was a problem hiding this comment.
Hm. is "eventsource.min.js" required here?
Author
There was a problem hiding this comment.
Well, it should be when you distribute it via bower :)
Owner
|
also, is it possible to not have "eventsource.min.js" in the repo? |
Author
|
it must exist at least when you tag this version as stable 0.0.1 in git. after, you can delete as the master branch you be the development one. |
Author
|
there. or we could split eventsource.js and eventsource.min.js between src and dist folders, but in general packages in bower have the source version and a minified version, ready for distribution. |
Owner
|
@vltr , not good |
Yaffle
added a commit
that referenced
this pull request
Jun 12, 2014
uglifyjs license fix, grunt support, bower support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! as i described, here's the pull request to create a lot of stuff :) after accepting, please, create a tag named "0.0.1" so i can publish the package to the bower main database! :)