fix(data-access): batch getAllFixesWithSuggestionsByOpportunityId (SITES-45307)#1619
Open
mimchome wants to merge 3 commits into
Open
fix(data-access): batch getAllFixesWithSuggestionsByOpportunityId (SITES-45307)#1619mimchome wants to merge 3 commits into
mimchome wants to merge 3 commits into
Conversation
… (SITES-45307) Extract shared grouping logic into #buildFixesWithSuggestions and add getAllFixesWithSuggestionsByOpportunityId that queries the junction table by opportunityId only (3 PostgREST calls total instead of 2N+1).
2 tasks
|
This PR will trigger a patch release when merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SITES-45307
Problem
GET /sites/:siteId/opportunities/:oppId/fixesfetches suggestions per fix in a loop -- 2N+1 queries for N fixes. Follow-up from SITES-45274 which identified the pattern during the fixes controller review.Changes
getAllFixesWithSuggestionsByOpportunityIdtoFixEntityCollection-- queries byopportunityIdonly, 3 PostgREST calls total instead of 2N+1#buildFixesWithSuggestions, reused by both the new method and existinggetAllFixesWithSuggestionByCreatedAtConsumer: spacecat-api-service #2474 (draft, waiting on this publish)
Validated
Verified on CI dev -- fixes returned with suggestions embedded, matching existing response contract.
Test plan
getAllFixesWithSuggestionByCreatedAttests pass with shared helper