Skip to content

Commit 988e02b

Browse files
committed
Refactor UserModule to use constant for injection rather than string literals.
1 parent f433db9 commit 988e02b

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

domain/src/main/java/com/fernandocejas/android10/sample/domain/interactor/GetUserDetails.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
*/
2929
public class GetUserDetails extends UseCase {
3030

31+
public static final String NAME = "userDetails";
32+
3133
private final int userId;
3234
private final UserRepository userRepository;
3335

domain/src/main/java/com/fernandocejas/android10/sample/domain/interactor/GetUserList.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
*/
2929
public class GetUserList extends UseCase {
3030

31+
public static final String NAME = "userList";
32+
3133
private final UserRepository userRepository;
3234

3335
@Inject

presentation/src/main/java/com/fernandocejas/android10/sample/presentation/internal/di/modules/UserModule.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ public UserModule(int userId) {
4040
this.userId = userId;
4141
}
4242

43-
@Provides @PerActivity @Named("userList") UseCase provideGetUserListUseCase(
43+
@Provides @PerActivity @Named(GetUserList.NAME) UseCase provideGetUserListUseCase(
4444
GetUserList getUserList) {
4545
return getUserList;
4646
}
4747

48-
@Provides @PerActivity @Named("userDetails") UseCase provideGetUserDetailsUseCase(
48+
@Provides @PerActivity @Named(GetUserDetails.NAME) UseCase provideGetUserDetailsUseCase(
4949
UserRepository userRepository, ThreadExecutor threadExecutor,
5050
PostExecutionThread postExecutionThread) {
5151
return new GetUserDetails(userId, userRepository, threadExecutor, postExecutionThread);
5252
}
53-
}
53+
}

presentation/src/main/java/com/fernandocejas/android10/sample/presentation/presenter/UserDetailsPresenter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import com.fernandocejas.android10.sample.domain.exception.DefaultErrorBundle;
2121
import com.fernandocejas.android10.sample.domain.exception.ErrorBundle;
2222
import com.fernandocejas.android10.sample.domain.interactor.DefaultSubscriber;
23+
import com.fernandocejas.android10.sample.domain.interactor.GetUserDetails;
2324
import com.fernandocejas.android10.sample.domain.interactor.UseCase;
2425
import com.fernandocejas.android10.sample.presentation.exception.ErrorMessageFactory;
2526
import com.fernandocejas.android10.sample.presentation.internal.di.PerActivity;
@@ -43,7 +44,7 @@ public class UserDetailsPresenter implements Presenter {
4344
private final UserModelDataMapper userModelDataMapper;
4445

4546
@Inject
46-
public UserDetailsPresenter(@Named("userDetails") UseCase getUserDetailsUseCase,
47+
public UserDetailsPresenter(@Named(GetUserDetails.NAME) UseCase getUserDetailsUseCase,
4748
UserModelDataMapper userModelDataMapper) {
4849
this.getUserDetailsUseCase = getUserDetailsUseCase;
4950
this.userModelDataMapper = userModelDataMapper;

presentation/src/main/java/com/fernandocejas/android10/sample/presentation/presenter/UserListPresenter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import com.fernandocejas.android10.sample.domain.exception.DefaultErrorBundle;
2121
import com.fernandocejas.android10.sample.domain.exception.ErrorBundle;
2222
import com.fernandocejas.android10.sample.domain.interactor.DefaultSubscriber;
23+
import com.fernandocejas.android10.sample.domain.interactor.GetUserList;
2324
import com.fernandocejas.android10.sample.domain.interactor.UseCase;
2425
import com.fernandocejas.android10.sample.presentation.exception.ErrorMessageFactory;
2526
import com.fernandocejas.android10.sample.presentation.internal.di.PerActivity;
@@ -44,7 +45,7 @@ public class UserListPresenter implements Presenter {
4445
private final UserModelDataMapper userModelDataMapper;
4546

4647
@Inject
47-
public UserListPresenter(@Named("userList") UseCase getUserListUserCase,
48+
public UserListPresenter(@Named(GetUserList.NAME) UseCase getUserListUserCase,
4849
UserModelDataMapper userModelDataMapper) {
4950
this.getUserListUseCase = getUserListUserCase;
5051
this.userModelDataMapper = userModelDataMapper;

0 commit comments

Comments
 (0)