Migrate from os.system to subprocess.Popen #38
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33: Migration to "subprocess" for executing commands
Improvements:
subprocess.Popeninstead ofos.systemfor compilation and execution statements.stdinandstdoutare controlled i. e. Both are set insubprocess.PIPEand manually controlled usingobj.stdinandobj.communicate().os.path.join. The use of '/' as a separator might cause unexpected issues in several systems;os.pathtakes care of that.The problem mentioned in #31 caused by whitespaces in the directory/file names is no longer a problem after the use of
subprocess. The arguments are passed as an array tosubprocess.Popen, which takes care of escaping the characters in an OS-agnostic way to avoid any possible error:The changes have been tested and Codemon successfully works in both GNU/UNIX-like (MSYS2,
bash, WSL2,xterm) Windows (cmd.exe, PowerShell) environments.