Remove buggy retry code finally

Author: nythepegasus

AltStore/Operations/DeactivateAppOperation.swift

@@ -39,21 +39,14 @@ final class DeactivateAppOperation: ResultOperation<InstalledApp>
             let allIdentifiers = [installedApp.resignedBundleIdentifier] + appExtensionProfiles
 
             for profile in allIdentifiers {
-                var attempts = 5
-                while (attempts > 0){
-                    print("Remove Provisioning profile attempts left: \(attempts)")
-                    do {
-                        try remove_provisioning_profile(profile)
-                        self.progress.completedUnitCount += 1
-                        installedApp.isActive = false
-                        self.finish(.success(installedApp))
-                        break
-                    } catch {
-                        attempts -= 1
-                        if (attempts <= 0){
-                            self.finish(.failure(error))
-                        }
-                    }
+                do {
+                    try remove_provisioning_profile(profile)
+                    self.progress.completedUnitCount += 1
+                    installedApp.isActive = false
+                    self.finish(.success(installedApp))
+                    break
+                } catch {
+                    self.finish(.failure(error))
                 }
             }
         }

AltStore/Operations/EnableJITOperation.swift

@@ -50,7 +50,7 @@ final class EnableJITOperation<Context: EnableJITContext>: ResultOperation<Void>
                 do {
                     try debug_app(installedApp.resignedBundleIdentifier)
                     self.finish(.success(()))
-                    break
+                    retries = 0
                 } catch {
                     retries -= 1
                     if (retries <= 0){

AltStore/Operations/RefreshAppOperation.swift

@@ -41,19 +41,11 @@ final class RefreshAppOperation: ResultOperation<InstalledApp>
             guard let app = self.context.app else { return self.finish(.failure(OperationError.appNotFound)) }
 
             for p in profiles {
-                var attempts = 5
-                while (attempts > 0){
-                    print("Install provisioning profile attempts left: \(attempts)")
-                    do {
-                        let bytes = p.value.data.toRustByteSlice()
-                        try install_provisioning_profile(bytes.forRust())
-                        break
-                    } catch {
-                        attempts -= 1
-                        if (attempts <= 0) {
-                            self.finish(.failure(MinimuxerError.ProfileInstall))
-                        }
-                    }
+                do {
+                    let bytes = p.value.data.toRustByteSlice()
+                    try install_provisioning_profile(bytes.forRust())
+                } catch {
+                    self.finish(.failure(MinimuxerError.ProfileInstall))
                 }
 
                 DatabaseManager.shared.persistentContainer.performBackgroundTask { (context) in

AltStore/Operations/SendAppOperation.swift

@@ -45,21 +45,13 @@ final class SendAppOperation: ResultOperation<()>
         print("AFC App `fileURL`: \(fileURL.absoluteString)")
 
         if let data = NSData(contentsOf: fileURL) {
-            var attempts = 10
-            while (attempts != 0){
-                print("Send app attempts left: \(attempts)")
-                do {
-                    let bytes = Data(data).toRustByteSlice()
-                    try yeet_app_afc(app.bundleIdentifier, bytes.forRust())
-                    self.progress.completedUnitCount += 1
-                    self.finish(.success(()))
-                    break
-                } catch {
-                    attempts -= 1
-                    if (attempts <= 0) {
-                        self.finish(.failure(MinimuxerError.RwAfc))
-                    }
-                }
+            do {
+                let bytes = Data(data).toRustByteSlice()
+                try yeet_app_afc(app.bundleIdentifier, bytes.forRust())
+                self.progress.completedUnitCount += 1
+                self.finish(.success(()))
+            } catch {
+                self.finish(.failure(MinimuxerError.RwAfc))
                 self.progress.completedUnitCount += 1
                 self.finish(.success(()))
             }