Skip to content

Commit dbf9d13

Browse files
authored
[DOCS] Fix failing R tests after update of dbplyr (#1077)
1 parent 97258a3 commit dbf9d13

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

R/tests/testthat/test-data-interface.R

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ test_that("spark_read_geoparquet() works as expected", {
309309
)
310310

311311
## Right registered name
312-
expect_equal(geoparquet_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
312+
expect_equal(geoparquet_sdf %>% dbplyr::remote_name(), sdf_name)
313313

314314
## Right schema
315315
expect_equivalent(
@@ -442,7 +442,7 @@ test_that("spark_read_geoparquet() throws an error with plain parquet files", {
442442

443443
expect_error(
444444
spark_read_geoparquet(sc, geoparquet("plain.parquet")),
445-
regexp = "GeoParquet file does not contain valid geo"
445+
regexp = "not contain valid geo"
446446
)
447447

448448
})
@@ -463,7 +463,7 @@ test_that("spark_read_geojson() works as expected", {
463463
)
464464

465465
## Right registered name
466-
expect_equal(geojson_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
466+
expect_equal(geojson_sdf %>% dbplyr::remote_name(), sdf_name)
467467

468468
})
469469

@@ -478,7 +478,7 @@ test_that("spark_read_geojson() works as expected, no feat", {
478478
)
479479

480480
## Right registered name
481-
expect_equal(geojson_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
481+
expect_equal(geojson_sdf %>% dbplyr::remote_name(), sdf_name)
482482

483483
sc %>% DBI::dbExecute(paste0("DROP TABLE ", sdf_name))
484484

@@ -494,7 +494,7 @@ test_that("spark_read_geojson() works as expected, null values", {
494494
)
495495

496496
## Right registered name
497-
expect_equal(geojson_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
497+
expect_equal(geojson_sdf %>% dbplyr::remote_name(), sdf_name)
498498

499499
sc %>% DBI::dbExecute(paste0("DROP TABLE ", sdf_name))
500500

@@ -522,7 +522,7 @@ test_that("spark_read_geojson() works as expected, with id", {
522522
)
523523

524524
## Right registered name
525-
expect_equal(geojson_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
525+
expect_equal(geojson_sdf %>% dbplyr::remote_name(), sdf_name)
526526

527527
sc %>% DBI::dbExecute(paste0("DROP TABLE ", sdf_name))
528528

@@ -541,7 +541,7 @@ test_that("spark_read_geojson() works as expected, invalid geom", {
541541
)
542542

543543
## Right registered name
544-
expect_equal(geojson_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
544+
expect_equal(geojson_sdf %>% dbplyr::remote_name(), sdf_name)
545545

546546

547547
# Remove invalid
@@ -553,7 +553,7 @@ test_that("spark_read_geojson() works as expected, invalid geom", {
553553
)
554554

555555
## Right registered name
556-
expect_equal(geojson_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
556+
expect_equal(geojson_sdf %>% dbplyr::remote_name(), sdf_name)
557557

558558
sc %>% DBI::dbExecute(paste0("DROP TABLE ", sdf_name))
559559

@@ -676,13 +676,13 @@ test_that("spark_write_geojson() works as expected", {
676676

677677
## order of columns changes !
678678
expect_equal(
679-
names(geojson_sdf) %>% sort(),
680-
names(geojson_2_sdf) %>% sort()
679+
colnames(geojson_sdf) %>% sort(),
680+
colnames(geojson_2_sdf) %>% sort()
681681
)
682682
expect_equal(
683683
geojson_sdf %>% mutate(geometry = geometry %>% st_astext()) %>% collect(),
684684
geojson_2_sdf %>% mutate(geometry = geometry %>% st_astext()) %>% collect() %>%
685-
select(names(geojson_sdf))
685+
select(colnames(geojson_sdf))
686686
)
687687

688688

R/tests/testthat/test-sdf-interface.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ test_that("sdf_register() works as expected for Spatial RDDs", {
3636

3737
)
3838
)
39-
expect_equal(pt_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
39+
expect_equal(pt_sdf %>% dbplyr::remote_name(), sdf_name)
4040

4141
pt_sdf %>% collect()
4242
succeed()
@@ -68,7 +68,7 @@ test_that("sdf_register() works as expected for Spatial RDDs with fieldNames", {
6868
)
6969
)
7070

71-
expect_equal(polygon_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
71+
expect_equal(polygon_sdf %>% dbplyr::remote_name(), sdf_name)
7272

7373
polygon_sdf %>% collect()
7474
succeed()
@@ -91,7 +91,7 @@ test_that("as.spark.dataframe() works as expected for Spatial RDDs with non-spat
9191
attr_3 = list(name = "attr_3", type = "StringType")
9292
)
9393
)
94-
expect_equal(pt_sdf %>% dbplyr::remote_name(), dbplyr::ident(sdf_name))
94+
expect_equal(pt_sdf %>% dbplyr::remote_name(), sdf_name)
9595

9696
pt_sdf %>% collect()
9797
succeed()

0 commit comments

Comments
 (0)