Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit d09dc22

Browse files
authored
Attach workspace element to DOM on the spec (#205)
* Use jasmine.attachToDOM to fix failing specs Atom now uses window.customElements instead of document.registerElement. That change caused the specs to fail. It seems while using customElements we have to attach the workspace element to the DOM. * Add pull request to the CI triggers
1 parent ccfb3fa commit d09dc22

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: CI
22

3-
on: [push]
3+
on: [push, pull_request]
44

55
env:
66
CI: true

spec/notifications-log-spec.coffee

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ describe "Notifications Log", ->
1010
beforeEach ->
1111
workspaceElement = atom.views.getView(atom.workspace)
1212
atom.notifications.clear()
13+
jasmine.attachToDOM(workspaceElement)
1314

1415
waitsForPromise ->
1516
atom.packages.activatePackage('notifications')

0 commit comments

Comments
 (0)