many: add meson project files

Author: valentindavid

.clang-format-include

@@ -0,0 +1,11 @@
+cmd/libsnap-confine-private/*
+cmd/snap-confine/*
+cmd/snap-device-helper/*
+cmd/snap-discard-ns/*
+cmd/snap-gdb-shim/*
+cmd/snap-update-ns/*
+cmd/snapd-env-generator/*
+cmd/snapd-generator/*
+cmd/system-shutdown/*
+cmd/snap-cli-wrap/*
+cmd/snapd-tool-wrap/*

checks/bad_match.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+
+set -eu
+
+badMATCH=$(find tests -name 'task.yaml' -print0 -o -name 'spread.yaml' -print0 |
+        xargs -0 grep -R -n -E 'MATCH +-v' || true)
+if [ -n "$badMATCH" ]; then
+    echo "Potentially incorrect use of MATCH -v at the following locations:" >&2
+    echo "$badMATCH" >&2
+    exit 1
+fi

checks/bad_multiline.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+
+set -eu
+
+badmultiline=$(find tests -name 'task.yaml' -print0 -o -name 'spread.yaml' -print0 |
+        xargs -0 grep -R -n -E '(restore*|prepare*|execute|debug):\s*$' || true)
+if [ -n "$badmultiline" ]; then
+    echo "Incorrect multiline strings at the following locations:" >&2
+    echo "$badmultiline" >&2
+    exit 1
+fi

checks/check_mountinfo_override.sh

@@ -0,0 +1,52 @@
+#!/bin/bash
+
+set -eu
+
+# This check verifies that interfaces that grant access to /proc/self/mountinfo
+# (directly or not) also have a prioritized override (see basePrioritizedSnippets
+# in interfaces/apparmor/template.go for why this is necessary). We do this
+# by looking for a "AddPrioritizedSnippet(*, apparmor.MountInfoKey, ...)" call
+# for any such interfaces.
+
+missing_override=""
+
+for f in interfaces/builtin/*.go; do
+    if [[ "$f" == *"_test.go" ]]; then
+        continue
+    fi
+
+    out=$(awk '
+            # if a prioritized override is present, we can stop early
+            /AddPrioritizedSnippet\(.* apparmor\.MountInfoKey/ { m=""; exit }
+
+            # We look for the following types of rules:
+            #   * Explicit mountinfo rules. For example, any combination of:
+            #      owner /proc/self/mountinfo r,
+            #      @{PROC}/@{pid} rw,
+            #      /proc/1234/mountinfo
+            #   * References to the "mountInfoSnippet" variable which contains
+            #      the same rules as the previous item
+            #   * Broad /proc grants:
+            #      owner @{PROC}/** r,
+            #      /proc/** rw,
+            #   * Relevant "allow" rules:
+            #      allow file
+            #      allow all
+
+            /^[[:space:]]*(owner[[:space:]]+)?(\/proc|@\{PROC\})\/(self|@\{pid\}|[0-9]+)\/mountinfo[[:space:]][a-z]*r[a-z]*,/ ||
+            /^[[:space:]]*(owner[[:space:]]+)?(\/proc|@\{PROC\})\/\*\*[[:space:]][a-z]*r[a-z]*,/ ||
+            /^[[:space:]]*allow[[:space:]]+(file|all),[[:space:]]*$/ ||
+            /mountInfoSnippet/ { m = m "      " NR ":" $0 ORS }
+            END { if (m != "") printf "  - %s:\n%s", FILENAME, m }
+        ' "$f")
+    [ -n "$out" ] && missing_override+="${out}"$'\n'
+done
+
+if [ -n "$missing_override" ]; then
+    echo "" >&2
+    echo "These interfaces allow access to /proc/*/mountinfo (specifically or not)" >&2
+    echo "without adding the allow rule as a prioritized snippet" >&2
+    echo "(see basePrioritizedSnippets in interfaces/apparmor/template.go):" >&2
+    printf "%s" "$missing_override" >&2
+    exit 1
+fi

checks/equals.sh

@@ -0,0 +1,9 @@
+#!/bin/bash
+
+set -eu
+
+if got=$(grep -n -R -E "(\!=|==|Equals,) (state\.)?ErrNoState" --include=*.go); then
+    echo "Don't use equality checks with ErrNoState, use errors.Is() instead" >&2
+    echo "$got" >&2
+    exit 1
+fi

checks/forbidden_cmd_go_deps.sh

@@ -0,0 +1,39 @@
+#!/bin/bash
+
+set -eu
+
+forbidden_deps=(
+    "github.com/snapcore/snapd/testutil"
+    "gopkg.in/check.v1"
+)
+go_list_cmd=(go list)
+
+if [ -n "${GO_BUILD_TAGS:-}" ]; then
+    go_list_cmd+=(-tags "$GO_BUILD_TAGS")
+fi
+
+cmd_mains=$("${go_list_cmd[@]}" -f '{{if eq .Name "main"}}{{.ImportPath}}{{end}}' ./cmd/...)
+
+violations=()
+
+for cmd_main in $cmd_mains; do
+    deps=$("${go_list_cmd[@]}" -deps "$cmd_main")
+
+    for dep in "${forbidden_deps[@]}"; do
+        if grep -qx "$dep" <<<"$deps"; then
+            violations+=("$cmd_main -> $dep")
+        fi
+    done
+done
+
+if [ ${#violations[@]} -gt 0 ]; then
+    echo "Go binaries must not depend on forbidden packages:" >&2
+    for dep in "${forbidden_deps[@]}"; do
+        echo "  - $dep" >&2
+    done
+    echo "Violations:" >&2
+    for violation in "${violations[@]}"; do
+        echo "  - $violation" >&2
+    done
+    exit 1
+fi

checks/gofmt.sh

@@ -0,0 +1,19 @@
+#!/bin/bash
+
+set -eu
+
+fmt=""
+
+for dir in $(go list -f '{{.Dir}}' ./...); do
+    s="$(gofmt -s -d "$dir" || true)"
+    if [ -n "$s" ]; then
+        fmt="$s\\n$fmt"
+    fi
+done
+
+if [ -n "$fmt" ]; then
+    echo "Formatting wrong in following files:"
+    # shellcheck disable=SC2001
+    echo "$fmt" | sed -e 's/\\n/\n/g'
+    exit 1
+fi

checks/gopath.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+
+set -eu
+
+regexp='GOPATH(?!%%:\*)(?!:)[^= ]*/'
+if grep -qPr --exclude HACKING.md --exclude 'Makefile.*' --exclude '*.qcow2' --exclude-dir .git --exclude-dir vendor "$regexp"; then
+    echo "Using GOPATH as if it were a single entry and not a list:" >&2
+    grep -PHrn -C1 --color=auto --exclude HACKING.md --exclude 'Makefile.*' --exclude '*.qcow2' --exclude-dir .git --exclude-dir vendor "$regexp"
+    echo "Use GOHOME, or {GOPATH%%:*}, instead." >&2
+    exit 1
+fi

checks/http_status.sh

@@ -0,0 +1,17 @@
+#!/bin/bash
+
+set -eu
+
+got=""
+for dir in $(go list -f '{{.Dir}}' ./...); do
+    s="$(grep -nP 'http\.Status(?!Text)' "$dir"/*.go || true)"
+    if [ -n "$s" ]; then
+        got="$s\\n$got"
+    fi
+done
+
+if [ -n "$got" ]; then
+    echo 'Usages of http.Status*, we prefer the numeric values directly:' >&2
+    echo "$got" >&2
+    exit 1
+fi

checks/ioutil.sh

@@ -0,0 +1,18 @@
+#!/bin/bash
+
+set -eu
+
+got=""
+for dir in $(go list -f '{{.Dir}}' ./...); do
+    # shellcheck disable=SC2063
+    s="$(grep -nP io/ioutil "$dir"/*.go || true)"
+    if [ -n "$s" ]; then
+        got="$s\\n$got"
+    fi
+done
+
+if [ -n "$got" ]; then
+    echo 'Found usages of deprecated io/ioutil, please use "io" or "os" equivalents' >&2
+    echo "$got" >&2
+    exit 1
+fi