CHECK at TEST_CASE level ignores logging?

[sd-x]

Given this program:

#define CATCH_CONFIG_MAIN
#include "catch2/catch.hpp"

int x = 0;

TEST_CASE("my case", "[foo]") {
  auto y = 1-x;
  CAPTURE(y);
  SECTION("my section") {
    // CHECK(false);  // If uncomment this, I see the CAPTURE message for it
  }
  CHECK(false); // I expect the message for this line to show 'y := 1', but it's missing
}

I do not see the

with message:
  y := 1

in the output (when run default options). INFO behaves similarly.

my g++ is 7.3.0 and my Catch2 is v2.9.2

[amitherman95]

I'm on it

[Ext3h]

RunContext::sectionEnded(SectionEndInfo const & endInfo) appears to behave faulty. It is clearing both m_messageScopes (un-scoped messages) and m_messages (messages wich scope is strictly handled by RAII style scope objects).

Clearing m_messageScopes is in line with the documentation. Clearing m_messages goes against it.

There is also a second, similar bug in RunContext::popScopedMessage(MessageInfo const & message), if a message with an identical text has been also added by an inner scope, both the inner and outer captures are removed. RunContext::popScopedMessage(MessageInfo const & message) should only remove a single instance of the message in this case, searching from the top of the scoped message stack.