Second event handler not correctly registered

[stephanebisson]

It appears that on an element having more than one event handlers (on* attributes), the second one is not correctly registered but the first and third ones are. I haven't tried with more than 3.

Test case: https://codepen.io/stephanebisson/pen/yLrWgzL?editors=1010

[hueitan]

The issue causing the second item to be skipped is that the previous attributes are being removed while the loop is still running. To fix this, we should wait until after the loop has finished to remove the attributes.

reef/src/components/render.js

Lines 187 to 194 in ca459f0

	for (let {name, value} of elem.attributes) {
	// If the attribute should be skipped, remove it
	if (skipAttribute(name, value)) {
	removeAttribute(elem, name);
	listen(elem, name, value, events);
	continue;
	}

[cferdinandi]

Fixed!

[stephanebisson]

According to this codepen, v13.0.4 broke this again

[hueitan]

According to this codepen, v13.0.4 broke this again

fixed on #204

[stephanebisson]

The PR above seems to fix the issue. @cferdinandi any chance you can have a look? thanks

[cferdinandi]

A recent update reintroduced this bug, unfortunately

[cferdinandi]

I'm considering dropping on* support entirely.

I'm increasingly convinced it's a bad pattern.