`Either` uses `value` instead of `contents`

[peterbecich]

Unsure if this belongs to argonaut-aeson-generic, or Argonaut.

Here's a few test datatypes in PureScript:

data TestSum
  = Nullary
  | Bool Boolean
  | Int Int
  | Number Number

data TestData
  = TMaybe (Maybe TestSum)
  | TEither String

newtype Foo = Foo
  { _fooE :: Either String Int
  , _fooTestSum :: TestSum
  , _fooTestData :: TestData
  }

and test value:

testFoo = Foo
  { _fooE: Left "foo"
  , _fooTestSum: Nullary
  , _fooTestData: TEither "foo"
  }

Options are:

ops :: Options
ops = Options
  { sumEncoding: TaggedObject { tagFieldName: "tag", contentsFieldName: "contents" }
  , tagSingleConstructors: true
  , allNullaryToStringTag: true
  }

Encoding to JSON:

z = genericEncodeAeson ops testFoo
log $ stringify $ z

the result is:

{
  "_fooTestSum": {
    "tag": "Nullary"
  },
  "_fooTestData": {
    "tag": "TEither",
    "contents": "foo"
  },
  "_fooE": {
    "tag": "Left",
    "value": "foo"
  }
}

The made-up type TEither correctly uses "contents". The standard library Either uses "value".

I think this breaks compatibility with Aeson on the Haskell side, which uses "contents" for all datatypes.

It looks like Argonaut is picking up the encoding options from somewhere else, for the Either.

I am trying to update Purescript Bridge using argonaut-aeson-generic: eskimor/purescript-bridge#89

[peterbecich]

This might be fixed by overriding https://github.com/purescript-contrib/purescript-argonaut-codecs/blob/50e79f6cd526f875a1e93477aafd4ed98f270266/src/Data/Argonaut/Decode/Decoders.purs#L69
to make it consistent with https://hackage.haskell.org/package/aeson-2.2.1.0/docs/Data-Aeson.html#v:defaultTaggedObject

[peterbecich]

I think related to #6