Skip to content

[UUF] Don't catch all exceptions #11240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gewarren opened this issue Apr 25, 2025 · 1 comment · Fixed by #11274
Closed

[UUF] Don't catch all exceptions #11240

gewarren opened this issue Apr 25, 2025 · 1 comment · Fixed by #11274
Labels
area-System.IO help wanted Good for community contributors to help [up-for-grabs] user-feedback

Comments

@gewarren
Copy link
Contributor

Type of issue

Other (describe below)

Description

Why is the example catching all exceptions? We have clearly documented what the exceptions are and not following our own doc. This is a bad precedent to set for our customers.

Page URL

https://learn.microsoft.com/en-us/dotnet/api/system.io.directory.createdirectory?view=net-9.0

Content source URL

https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System.IO/Directory.xml

Document Version Independent Id

94e4ec5d-b7bc-0306-7d10-90778a66817a

Platform Id

23cc4013-8b62-3b4c-df47-f3692abdf742

Article author

@dotnet-bot
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2025
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 25, 2025
@gewarren gewarren changed the title [UUF] Don't call all exceptions [UUF] Don't catch all exceptions Apr 25, 2025
@gewarren gewarren added help wanted Good for community contributors to help [up-for-grabs] area-System.IO and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 25, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io

@adamsitnik adamsitnik mentioned this issue May 6, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.IO help wanted Good for community contributors to help [up-for-grabs] user-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't catch all exceptions in Directory.CreateDirectory example dotnet/dotnet-api-docs
1 participant
@gewarren