Revert "refactor(popover): switch to data-hidden instead of data-hide to follow bootstrap events"

This reverts commit 0b2026e.

Author: mgcrea

src/directives/popover.js

@@ -48,9 +48,9 @@ angular.module('$strap.directives')
           });
         }
 
-        // Handle data-hidden attribute to toggle visibility
-        if(!!attr.hidden) {
-          scope.$watch(attr.hidden, function(newValue, oldValue) {
+        // Handle data-hide attribute to toggle visibility
+        if(!!attr.hide) {
+          scope.$watch(attr.hide, function(newValue, oldValue) {
             if(!!newValue) {
               popover.hide();
             } else if(newValue !== oldValue) {

test/unit/directives/popoverSpec.js

@@ -31,10 +31,10 @@ describe('popover', function () {
       popover: 'Hello <span ng-bind-html-unsafe="content"></span>',
       element: '<a class="btn" bs-popover="\'partials/popover.html\'" data-title="aTitle" data-unique="1"></a>'
     },
-    'hidden': {
-      scope: {content: "World<br />Multiline Content<br />", foo: {hidden: false}},
+    'hide': {
+      scope: {content: "World<br />Multiline Content<br />", foo: {hide: false}},
       popover: 'Hello <span ng-bind-html-unsafe="content"></span>',
-      element: '<a class="btn" bs-popover="\'partials/popover.html\'" data-title="aTitle" data-hidden="foo.hidden"></a>'
+      element: '<a class="btn" bs-popover="\'partials/popover.html\'" data-title="aTitle" data-hide="foo.hide"></a>'
     },
     'object': {
       scope: {popover: {title: "aTitle", content: "World<br />Multiline Content<br />"}},
@@ -127,12 +127,12 @@ describe('popover', function () {
     //expect(elm.data('popover').tip().hasClass('in')).toBe(false);
   });
 
-  it('should support data-hidden attribute', function() {
-    var elm = compileDirective('hidden');
+  it('should support data-hide attribute', function() {
+    var elm = compileDirective('hide');
     elm.trigger('click');
     expect(elm.data('popover').tip().hasClass('in')).toBe(true);
-    scope.foo.hidden = true;
-    scope.$digest();
+    scope.foo.hide = true;
+    scope.$digest(); // $digest already in progress
     expect(elm.data('popover').tip().hasClass('in')).toBe(false);
   });