Skip to content

Conversation

@clintkitson
Copy link
Member

This commit updates the volume API implementation to leverage
the Docker v1.11.0. There was an addition of Get() and List()
methods in prior v1.10. The Get() method now replaces the
call that implicitly created volumes. The Create() method
was used for Path() and other methods prior because there
was no Get() method that returned a volume object.

@clintkitson
Copy link
Member Author

root@mesos-master:/home/vagrant# ./dvdcli --volumedriver=rexray --volumename=test45 mount --explicitcreate=true
ERRO[0000] VolumeDriver.Get: {"Error":"No volumes returned"}
  volumeName=test45
root@mesos-master:/home/vagrant# ./dvdcli --volumedriver=rexray --volumename=test45 mount --explicitcreate=false
INFO[0012] /var/lib/rexray/volumes/test45/data          
/var/lib/rexray/volumes/test45/data

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 32.99% when pulling 8863446 on clintonskitson:feature/update_docker_v1.11.0_volumes into 3c3dcbe on emccode:master.

@clintkitson
Copy link
Member Author

The default behavior is the same as behavior, except there is no longer a create volume called in any case for Unmount() or Path(), a Get() is done instead to verify the volume exists or not. @cantbewong Can you verify that the mesos-module-dvdi will not be adversely affected if we error on missing volumes for Unmount() and Path() now?

The Mount() method now inherently is implict as before. But there is a specific flag to set it as explicit by --explicitcreate=true.

@gyliu513
Copy link

@clintonskitson when do you plan have this released? Can you please cut a branch and create a new release for it? Thanks.

@clintkitson
Copy link
Member Author

@Jay-Lau Have you had a chance to test and verify?

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.2%) to 32.99% when pulling e9dbe28 on clintonskitson:feature/update_docker_v1.11.0_volumes into 6d7cdf1 on emccode:master.

@clintkitson clintkitson force-pushed the feature/update_docker_v1.11.0_volumes branch 2 times, most recently from cc943eb to fe00446 Compare April 18, 2016 19:40
This commit updates the volume API implementation to leverage
the Docker v1.11.0. There was an addition of Get() and List()
methods in prior v1.10. The Get() method now replaces the
call that implicitly created volumes. The Create() method
was used for Path() and other methods prior because there
was no Get() method that returned a volume object.
@clintkitson clintkitson force-pushed the feature/update_docker_v1.11.0_volumes branch from fe00446 to 9b4cdfa Compare April 18, 2016 19:44
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.2%) to 32.99% when pulling fe00446 on clintonskitson:feature/update_docker_v1.11.0_volumes into 6d7cdf1 on emccode:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.2%) to 32.99% when pulling fe00446 on clintonskitson:feature/update_docker_v1.11.0_volumes into 6d7cdf1 on emccode:master.

@clintkitson clintkitson merged commit 03f6e43 into rexray:master Apr 18, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.2%) to 32.99% when pulling 9b4cdfa on clintonskitson:feature/update_docker_v1.11.0_volumes into 6d7cdf1 on emccode:master.

@clintkitson
Copy link
Member Author

clintkitson commented Apr 18, 2016

@Jay-Lau

curl -sSL https://dl.bintray.com/emccode/dvdcli/install | sh -s staged
root@mesos-master:/home/vagrant# dvdcli --volumedriver=docker --volumename=test111123 mount --explicitcreate=true
ERRO[0000] VolumeDriver.Get: {"Error":"No volumes returned"}
  volumeName=test111123
root@mesos-master:/home/vagrant# dvdcli --volumedriver=docker --volumename=test111123 mount --explicitcreate=false
INFO[0000] /var/lib/rexray/volumes/test111123/data      
/var/lib/rexray/volumes/test111123/data

@gyliu513
Copy link

@clintonskitson when do you want to have a stable version of 0.2.0? I saw that current version is 0.2.0-rc1

root@mesos002:~/src/mesos/m2/mesos/build# dvdcli version
Binary: /usr/bin/dvdcli
SemVer: 0.2.0-rc1
OsArch: Linux-x86_64
Branch: v0.2.0-rc1
Commit: a789d3ddde4fa9ce3201e3f7bd5ca0cec10a9132
Formed: Tue, 19 Apr 2016 03:55:17 CST

@clintkitson
Copy link
Member Author

Planning on it today.

On Wednesday, April 20, 2016, Guangya Liu [email protected] wrote:

@clintonskitson https://github.com/clintonskitson when do you want to
have a stable version of 0.2.0? I saw that current version is 0.2.0-rc1

root@mesos002:~/src/mesos/m2/mesos/build# dvdcli version
Binary: /usr/bin/dvdcli
SemVer: 0.2.0-rc1
OsArch: Linux-x86_64
Branch: v0.2.0-rc1
Commit: a789d3d
Formed: Tue, 19 Apr 2016 03:55:17 CST


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#20 (comment)

@clintkitson
Copy link
Member Author

@gyliu513
Copy link

Cool! Thanks @clintonskitson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants