Refactor transaction intrinsic gas calculation #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodiazet
approved these changes
Jan 17, 2025
4da88a4 to
76b5c0f
Compare
- Compute transaction data cost using "token" count from EIP-7623. - Clean up related constants. - Treat creation as additional cost (`TX_CREATE_COST`).
76b5c0f to
90245f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 159 159
Lines 17296 17298 +2
=======================================
+ Hits 16312 16314 +2
Misses 984 984
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
added a commit
that referenced
this pull request
Jan 20, 2025
This implements [EIP-7623](https://eips.ethereum.org/EIPS/eip-7623). In effect, during transaction validation we compute minimal transaction gas cost. After transaction execution the amount of gas used is increased to this value if lower. Requires #1107 #1108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TX_CREATE_COST).