Make small push value parsing endianness independent #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way is also faster.
gumb0
reviewed
Sep 17, 2019
| *insert_pos++ = *code_pos++; | ||
| instr.arg.small_push_value = load64be(value_bytes); | ||
| { | ||
| value |= uint64_t{*code_pos++} << insert_bit_pos; |
Member
There was a problem hiding this comment.
Could it still be in a separate helper function maybe?
Member
Author
There was a problem hiding this comment.
The load64be was only doing bswap. I would need to extract whole case:.
Member
Author
There was a problem hiding this comment.
I pushed an example how it could look like, but it is up to 30% slower.
Member
There was a problem hiding this comment.
Wow then let's leave it, if it's so much slower (why, can't be inlined sometimes?)
push_end change looks fine, though
Member
Author
There was a problem hiding this comment.
I think returning multiple values and using tuple and std::tie messes it up. But I'm only guessing. I'd need much more time to investigate.
gumb0
approved these changes
Sep 17, 2019
45f1c21 to
95b9b04
Compare
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 85.31% 86.44% +1.13%
==========================================
Files 22 22
Lines 2261 2258 -3
Branches 219 220 +1
==========================================
+ Hits 1929 1952 +23
+ Misses 305 279 -26
Partials 27 27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes it faster.
Skylake Mobile:
Haswell: