Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Sep 28, 2022

EOF does not require code padding for execution as executable code must end with terminating instruction.
This also refactors code analysis and execution state.

@chfast chfast force-pushed the analysis_executable_code branch from cf584db to c1eca5b Compare September 28, 2022 12:13
@chfast chfast requested a review from gumb0 September 28, 2022 12:13
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #508 (53305d4) into master (9f4eef7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   99.41%   99.41%   -0.01%     
==========================================
  Files          53       54       +1     
  Lines        5264     5258       -6     
==========================================
- Hits         5233     5227       -6     
  Misses         31       31              
Flag Coverage Δ
blockchaintests 77.78% <56.52%> (-0.08%) ⬇️
statetests 7.58% <0.00%> (+0.01%) ⬆️
unittests 99.55% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/evmone/execution_state.hpp 94.54% <ø> (-0.20%) ⬇️
test/unittests/execution_state_test.cpp 100.00% <ø> (ø)
lib/evmone/baseline.cpp 100.00% <100.00%> (ø)
lib/evmone/baseline.hpp 100.00% <100.00%> (ø)
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)

@chfast chfast force-pushed the analysis_executable_code branch from c1eca5b to 6f8875c Compare September 28, 2022 13:33
@chfast chfast force-pushed the analysis_executable_code branch from 6f8875c to 53305d4 Compare September 30, 2022 09:33
@chfast chfast merged commit 0897edb into master Sep 30, 2022
@chfast chfast deleted the analysis_executable_code branch September 30, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants