Skip to content

Conversation

@miles170
Copy link
Contributor

@miles170 miles170 commented Oct 6, 2022

Closes #511.

I haven't checked gas used in every benchmark loop iteration because I want to make sure current changes won't break anything.
After that, I'll add a check for gas used.

@miles170 miles170 force-pushed the migrate-to-state-test branch from 33d9044 to a93e10b Compare October 6, 2022 06:46
@axic axic requested a review from chfast October 20, 2022 11:33
@miles170 miles170 force-pushed the migrate-to-state-test branch 2 times, most recently from 0e16776 to f965a83 Compare October 21, 2022 02:16
@miles170 miles170 force-pushed the migrate-to-state-test branch 2 times, most recently from 66fce18 to c68c2df Compare October 21, 2022 12:50
@miles170 miles170 force-pushed the migrate-to-state-test branch 2 times, most recently from ab99342 to 439de19 Compare October 22, 2022 02:45
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #513 (ec9e5ae) into master (13a7873) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          54       54           
  Lines        5341     5344    +3     
=======================================
+ Hits         5291     5294    +3     
  Misses         50       50           
Flag Coverage Δ
blockchaintests 77.78% <ø> (ø)
statetests 7.55% <100.00%> (+0.05%) ⬆️
unittests 97.18% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/state/state.hpp 80.00% <ø> (ø)
test/statetest/statetest.hpp 100.00% <ø> (ø)
test/statetest/statetest_loader.cpp 81.35% <100.00%> (+0.48%) ⬆️

@miles170
Copy link
Contributor Author

miles170 commented Oct 22, 2022

Should I add more test cases to GeneralStateTests(https://github.com/ethereum/tests)?

@chfast
Copy link
Member

chfast commented Oct 22, 2022

Should I add more test cases to GeneralStateTests(https://github.com/ethereum/tests)?

If you are asking in context of code coverage, then this is not needed. We don't run the tests yet. But on the other hand it is always welcomed to add new tests if you have any ideas.

@chfast chfast force-pushed the migrate-to-state-test branch from 439de19 to b4c7a3c Compare October 22, 2022 13:39
@chfast chfast force-pushed the migrate-to-state-test branch from b4c7a3c to ec9e5ae Compare October 22, 2022 14:06
@chfast chfast merged commit f67b7da into ipsilon:master Oct 23, 2022
@miles170 miles170 deleted the migrate-to-state-test branch October 23, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to benchmarks in JSON format

2 participants