Skip to content

Conversation

@rodiazet
Copy link
Member

No description provided.

@rodiazet rodiazet requested a review from chfast March 30, 2023 14:09
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #607 (3316b08) into master (0028d4d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          74       74           
  Lines        7445     7445           
=======================================
  Hits         7230     7230           
  Misses        215      215           
Flag Coverage Δ
blockchaintests 63.55% <ø> (ø)
statetests 63.06% <100.00%> (ø)
unittests 93.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest_loader.cpp 88.46% <100.00%> (ø)

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There usually require a unit test.

@rodiazet rodiazet merged commit 476abd7 into master Mar 31, 2023
@rodiazet rodiazet deleted the handle-optional-to-field branch March 31, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants