Implement "CALLS 2.0" #630

axic · 2023-05-04T00:41:07Z

Closes #773

Implements EIP-7069, as part of the greater MegaEOF spec

codecov · 2023-05-04T01:02:59Z

Codecov Report

Attention: Patch coverage is 99.90079% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.14%. Comparing base (8358ba0) to head (e4fe3ca).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   97.99%   98.14%   +0.14%     
==========================================
  Files         121      122       +1     
  Lines       12091    12982     +891     
==========================================
+ Hits        11849    12741     +892     
+ Misses        242      241       -1

Flag	Coverage Δ
blockchaintests	`59.11% <3.77%> (-2.10%)`	⬇️
statetests	`62.36% <77.35%> (+0.45%)`	⬆️
statetests-silkpre	`21.61% <2.50%> (-1.52%)`	⬇️
unittests	`96.82% <99.90%> (+0.25%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
lib/evmone/advanced_instructions.cpp	`100.00% <ø> (ø)`
lib/evmone/baseline_instruction_table.cpp	`100.00% <ø> (ø)`
lib/evmone/instructions.hpp	`100.00% <ø> (ø)`
lib/evmone/instructions_calls.cpp	`100.00% <100.00%> (ø)`
test/unittests/eof_validation_test.cpp	`100.00% <100.00%> (ø)`
test/unittests/evm_calls_test.cpp	`100.00% <100.00%> (ø)`
test/unittests/evm_eof_calls_test.cpp	`100.00% <100.00%> (ø)`
test/unittests/instructions_test.cpp	`89.58% <ø> (ø)`
test/unittests/state_transition_call_test.cpp	`100.00% <100.00%> (ø)`
test/unittests/state_transition_eof_calls_test.cpp	`100.00% <100.00%> (ø)`
... and 1 more

... and 1 file with indirect coverage changes

lib/evmone/instructions_calls.cpp

lib/evmone/instructions.hpp

lib/evmone/instructions_opcodes.hpp

lib/evmone/instructions_calls.cpp

pdobacz · 2024-03-11T13:38:47Z

Uses tests from ethereum/tests#1350, which contains some changes on top of the currently used tag for testing EOF in CI state-tests.

pdobacz · 2024-03-19T17:00:04Z

Mind that I've pushed a test case to directly cover the recently discussed behavior of MIN_CALLEE_GAS here: 11cb4b0.

pdobacz · 2024-03-20T15:57:08Z

Also mind that the PR has been adjusted to the suggestion from here ethereum/EIPs#8287 (comment)

lib/evmone/instructions.hpp

test/unittests/CMakeLists.txt

test/utils/bytecode.hpp

lib/evmone/instructions_calls.cpp

gumb0 · 2024-03-22T14:59:31Z

lib/evmone/instructions_calls.cpp

+    const auto value = (Op == OP_EXTSTATICCALL || Op == OP_EXTDELEGATECALL) ? 0 : stack.pop();
+    const auto has_value = value != 0;
+
+    stack.push(2);  // Assume (hard) failure.


Also I think would be good to have named constants for status codes

heh, this invites a heated debate about naming, but let's try. I'll push a suggestion in a sec.

lib/evmone/instructions_calls.cpp

chfast

You should clean the git history and write better PR description

pdobacz · 2024-03-26T10:02:56Z

You should clean the git history and write better PR description

I don't think the git history is very useful in this case, it's a pretty atomic change, and the individual commits are mostly feedback addressing, renaming, bumps and backandforwards. This looks like a squash merge to me.

Implements [EIP-7069](https://eips.ethereum.org/EIPS/eip-7069),as part of the [MegaEOF spec](https://github.com/ipsilon/eof/blob/main/spec/eof.md). Adds implementation of EXTCALL, EXTDELEGATECALL and EXTSTATICCALL instructions.

Implements [EIP-7069](https://eips.ethereum.org/EIPS/eip-7069),as part of the [MegaEOF spec](https://github.com/ipsilon/eof/blob/main/spec/eof.md). Adds implementation of EXTCALL, EXTDELEGATECALL and EXTSTATICCALL instructions. Co-authored-by: pdobacz <[email protected]>

axic force-pushed the new-call branch 6 times, most recently from 388e252 to 8a63492 Compare May 4, 2023 00:54

axic commented May 4, 2023

View reviewed changes

lib/evmone/instructions_calls.cpp Outdated Show resolved Hide resolved

gumb0 reviewed May 4, 2023

View reviewed changes

pdobacz mentioned this pull request Jan 10, 2024

Implement EIP-7069 Revamped CALL instructions (as part of EOF) #773

Closed

pdobacz self-assigned this Feb 13, 2024

axic and others added 5 commits February 13, 2024 18:29

Implement "CALLS 2.0"

f59a974

Use proper return values

4100913

Remove max comparison

15fd84e

Remove stipend

ca2c938

Fix typo in newcall_impl

8e640b5

pdobacz force-pushed the new-call branch 2 times, most recently from 59bedbf to 2e43e86 Compare February 15, 2024 10:25

pdobacz added 3 commits March 4, 2024 16:34

Update unit tests

3e13050

Block CALLS 2.0 in advanced

85a0b93

Update unit tests, migrate some to state_transition tests

f763c87

pdobacz force-pushed the new-call branch from c28d831 to 9cb6a87 Compare March 4, 2024 15:36

Callee gas and retained gas logic

ecdc311

pdobacz force-pushed the new-call branch from 9cb6a87 to ecdc311 Compare March 4, 2024 15:53

pdobacz added 2 commits March 5, 2024 10:59

Merge branch 'master' into new-call

e671394

Remove one superfluous std::max in msg.gas calculation

1e3f7db

pdobacz mentioned this pull request Mar 6, 2024

Update EOF1_Calls to EXT*CALL from EIP-7069 ethereum/tests#1350

Closed

pdobacz added 3 commits March 6, 2024 15:14

Fix CI EOF tests to a branched revision

d5f0a5e

EVMC_PARIS can also be Paris in tests

1f2b912

Fix and test EXT*CALL status codes

ce0842a

pdobacz requested a review from chfast March 11, 2024 15:13

pdobacz added 2 commits March 13, 2024 12:36

Merge branch 'master' into new-call

3729ef1

Merge remote-tracking branch 'origin/master' into new-call

3e77953

pdobacz linked an issue Mar 14, 2024 that may be closed by this pull request

Implement EIP-7069 Revamped CALL instructions (as part of EOF) #773

Closed

pdobacz added 2 commits March 18, 2024 12:50

Merge remote-tracking branch 'origin/master' into new-call

e2eea7b

Add test case for the disputed behavior of MIN_CALLEE_GAS

11cb4b0

pdobacz added 2 commits March 20, 2024 16:31

Merge remote-tracking branch 'origin/master' into new-call

78d3bb0

Change the MIN_CALLEE_GAS failure to light

dfb02c3

chfast requested changes Mar 21, 2024

View reviewed changes

lib/evmone/instructions.hpp Outdated Show resolved Hide resolved

test/unittests/CMakeLists.txt Outdated Show resolved Hide resolved

test/utils/bytecode.hpp Outdated Show resolved Hide resolved

lib/evmone/instructions_calls.cpp Show resolved Hide resolved

Address PR feedback - CALLS 2.0

5de7675

pdobacz requested a review from chfast March 21, 2024 16:30

EOF tests by a tag

4dc8875

gumb0 reviewed Mar 22, 2024

View reviewed changes

lib/evmone/instructions_calls.cpp Outdated Show resolved Hide resolved

gumb0 reviewed Mar 22, 2024

View reviewed changes

lib/evmone/instructions_calls.cpp Outdated Show resolved Hide resolved

gumb0 reviewed Mar 22, 2024

View reviewed changes

pdobacz requested a review from gumb0 March 25, 2024 11:25

chfast reviewed Mar 26, 2024

View reviewed changes

lib/evmone/instructions_calls.cpp Outdated Show resolved Hide resolved

Address feedback - named constants

411785d

pdobacz force-pushed the new-call branch from 553c70a to 411785d Compare March 26, 2024 09:23

chfast approved these changes Mar 26, 2024

View reviewed changes

pdobacz added 2 commits March 26, 2024 15:24

Merge remote-tracking branch 'origin/master' into new-call

60d2166

Merge remote-tracking branch 'origin/master' into new-call

e4fe3ca

pdobacz merged commit 0b87c65 into master Mar 26, 2024

pdobacz deleted the new-call branch March 26, 2024 15:05

Implement "CALLS 2.0" #630

Implement "CALLS 2.0" #630

Uh oh!

Conversation

axic commented May 4, 2023 • edited by pdobacz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pdobacz commented Mar 11, 2024

Uh oh!

pdobacz commented Mar 19, 2024

Uh oh!

pdobacz commented Mar 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gumb0 Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

pdobacz Mar 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chfast left a comment

Choose a reason for hiding this comment

Uh oh!

pdobacz commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

axic commented May 4, 2023 •

edited by pdobacz

Loading

codecov bot commented May 4, 2023 •

edited

Loading