Skip to content

Conversation

@rodiazet
Copy link
Member

@rodiazet rodiazet commented Aug 22, 2023

Implement loading JSON block_number => block_hash map and expose it to Host::get_block_hash() via BlockInfo.

@rodiazet rodiazet requested a review from chfast August 22, 2023 12:21
@rodiazet rodiazet force-pushed the blockhash-support branch 2 times, most recently from 6d31815 to af4f012 Compare August 22, 2023 12:28
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #694 (a536c7d) into master (6608cf3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   97.51%   97.53%   +0.01%     
==========================================
  Files          86       86              
  Lines        8223     8249      +26     
==========================================
+ Hits         8019     8046      +27     
+ Misses        204      203       -1     
Flag Coverage Δ
blockchaintests 63.19% <ø> (ø)
statetests 74.20% <57.14%> (-0.07%) ⬇️
statetests-silkpre 23.20% <21.05%> (-0.02%) ⬇️
unittests 95.30% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
test/state/state.hpp 100.00% <ø> (ø)
test/state/host.cpp 92.78% <100.00%> (+0.63%) ⬆️
test/statetest/statetest_loader.cpp 90.33% <100.00%> (+0.16%) ⬆️
test/unittests/state_transition_block_test.cpp 100.00% <100.00%> (ø)
...est/unittests/statetest_loader_block_info_test.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@rodiazet rodiazet force-pushed the blockhash-support branch 2 times, most recently from 81c1255 to 26d009a Compare August 22, 2023 14:28
@rodiazet rodiazet requested a review from chfast August 22, 2023 15:28
@chfast chfast merged commit f5ca539 into master Aug 22, 2023
@chfast chfast deleted the blockhash-support branch August 22, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants