precompiles: Add evmone-precompiles-bench tool #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current results |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 110 110
Lines 10536 10536
=======================================
Hits 10315 10315
Misses 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pdobacz
approved these changes
Jan 3, 2024
test/state/precompiles.hpp
Outdated
| /// Executes the message to a precompiled contract (msg.code_address must be a precompile). | ||
| evmc::Result call_precompile(evmc_revision rev, const evmc_message& msg) noexcept; | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Superfluous newline here.
Consider moving the following declarations to a specialized precompiles_internal.hpp to not bloat the main API precompiles.hpp?
8d9f703 to
63682c7
Compare
Expose all `xxx_analyze()` and `xxx_execute()` functions from the `evmone::state` library. They are usable for tests and benchmarks. Make `EVMONE_PRECOMPILES_SILKPRE` compile definition available to the `evmone::state`s users.
Add new benchmarking tool `evmone-precompiles-bench` to compare performance of different precompiles implementations.
63682c7 to
d7181e6
Compare
pdobacz
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new benchmarking tool
evmone-precompiles-benchto compareperformance of different precompiles implementations.