Fix for missing NPM dependencies (#8624)

jamesdaniels · TrCaM · commit 249d35a9e43d · 2025-05-26T10:39:38.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,2 +1,3 @@
+- Fixed crash when starting the App Hosting emulator in certain applications (#8624)
 - Fixed issue where, with `webframeworks` enabled, `firebase init hosting` re-prompts users for source. (#8587)
 - Update typescript version in functions template to avoid build issue with @google-cloud/storage depedency (#8194)
diff --git a/src/emulator/apphosting/serve.ts b/src/emulator/apphosting/serve.ts
@@ -224,7 +224,7 @@ async function tripFirebasePostinstall(
     return;
   }
   const npmLsResults = JSON.parse(npmLs.stdout.toString().trim());
-  const dependenciesToSearch: Dependency[] = Object.values(npmLsResults.dependencies);
+  const dependenciesToSearch: Dependency[] = Object.values(npmLsResults.dependencies || {});
   const firebaseUtilPaths: string[] = [];
   for (const dependency of dependenciesToSearch) {
     if (

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
	`1`	`+- Fixed crash when starting the App Hosting emulator in certain applications (#8624)`
`1`	`2`	- Fixed issue where, with `webframeworks` enabled, `firebase init hosting` re-prompts users for source. (#8587)
`2`	`3`	`- Update typescript version in functions template to avoid build issue with @google-cloud/storage depedency (#8194)`
Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ async function tripFirebasePostinstall(`
`224`	`224`	`return;`
`225`	`225`	`}`
`226`	`226`	`const npmLsResults = JSON.parse(npmLs.stdout.toString().trim());`
`227`		`- const dependenciesToSearch: Dependency[] = Object.values(npmLsResults.dependencies);`
	`227`	`+ const dependenciesToSearch: Dependency[] = Object.values(npmLsResults.dependencies \|\| {});`
`228`	`228`	`const firebaseUtilPaths: string[] = [];`
`229`	`229`	`for (const dependency of dependenciesToSearch) {`
`230`	`230`	`if (`