Fix #2880 - generating email link from Admin SDK fails with Auth Emulator#2933
Merged
Conversation
bkendall
approved these changes
Dec 15, 2020
sam-gc
approved these changes
Dec 15, 2020
bkendall
added a commit
that referenced
this pull request
Dec 15, 2020
* Fix #2880 - generating email link from Admin SDK fails with Auth Emulator (#2933) * Fix #2880. * Add changelog entry. * fixes set-cookie issue (updated #2932) (#2939) * Fixes #2931 - Support multiple Set-Cookie headers apiv2.js uses node-fetch under the hood, which will concatenate duplicate headers with ', '. This is invalid for Set-Cookie headers. The solution is to grab the raw headers (which will be an array) and call `res.setHeader()` with that value. * add test * changelog Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com> * 8.20.0 * [firebase-release] Removed change log and reset repo after 8.20.0 release * auto fix audit issues * force audit update major versions * remove google-gax Co-authored-by: Yuchen Shi <yuchenshi@google.com> Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com> Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
bkendall
added a commit
that referenced
this pull request
Dec 15, 2020
* Removing code to handle legacy functions (#2935) * Disable Node.js 8 deploys for Cloud Functions. (#2934) * drop testing and support for node 8 (#2620) * remove/bump node 8s to node 10s * update some dev dependencies * update build target to es2017 * formatting * upgrade mocha * remove async types * update check in binary to node 8 * Update package.json * npm audit: breaking edition (#2941) * Fix #2880 - generating email link from Admin SDK fails with Auth Emulator (#2933) * Fix #2880. * Add changelog entry. * fixes set-cookie issue (updated #2932) (#2939) * Fixes #2931 - Support multiple Set-Cookie headers apiv2.js uses node-fetch under the hood, which will concatenate duplicate headers with ', '. This is invalid for Set-Cookie headers. The solution is to grab the raw headers (which will be an array) and call `res.setHeader()` with that value. * add test * changelog Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com> * 8.20.0 * [firebase-release] Removed change log and reset repo after 8.20.0 release * auto fix audit issues * force audit update major versions * remove google-gax Co-authored-by: Yuchen Shi <yuchenshi@google.com> Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com> Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com> Co-authored-by: joehan <joehanley@google.com> Co-authored-by: Michael Bleigh <bleigh@google.com> Co-authored-by: Yuchen Shi <yuchenshi@google.com> Co-authored-by: Adam Ahmed <72171617+adam-remotesocial@users.noreply.github.com> Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2880.
Scenarios Tested
See tests added.
Sample Commands
N/A