Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fnando/browser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: fnando/browser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 105 files changed
  • 1 contributor

Commits on Feb 27, 2018

  1. Change how bot handling works (#325)

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    f1a8450 View commit details
    Browse the repository at this point in the history

  2. Better wording.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    8c79946 View commit details
    Browse the repository at this point in the history

  3. Add Browser::Matchers to abstract lists.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    60299bd View commit details
    Browse the repository at this point in the history

  4. Extract all regexps into constants.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    4d467ae View commit details
    Browse the repository at this point in the history

  5. Remove code related checking if browser is modern.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    a027997 View commit details
    Browse the repository at this point in the history

  6. Inject methods as files are loaded. 

    This allows a lite loading approach (e.g. you may be interested only on mainstream browsers, or you want to detect only bots).

By default, this is what is being loaded:

- Main browsers (Safari, Chrome, IE/Edge, Firefox, Opera)
- Meta info (only for what's currently available)

To load lite mode, you have to require `browser/lite.rb` instead. Then, you can load other pieces of Browser you need (e.g. bot, platform, device).
    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    e773151 View commit details
    Browse the repository at this point in the history

  7. Remove Browser#modern? mentions.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    17cb639 View commit details
    Browse the repository at this point in the history

  8. Extract proxy? to its own file.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    e6aab0c View commit details
    Browse the repository at this point in the history

  9. Add support to Yandex and Chromium. Close #293.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    921ecbf View commit details
    Browse the repository at this point in the history

  10. Add instructions about how to add a new browser detection.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    7624302 View commit details
    Browse the repository at this point in the history

  11. Extract strings into constants.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    3799242 View commit details
    Browse the repository at this point in the history

  12. Improve browser template.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    101e303 View commit details
    Browse the repository at this point in the history

  13. Remove duplicated constant.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    77cf76e View commit details
    Browse the repository at this point in the history

  14. Don't use ActiveSupport for something trivial.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    8715b03 View commit details
    Browse the repository at this point in the history

  15. Don't detect Facebook webview and IEMobile as Safari. Close #329.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    55e3e9c View commit details
    Browse the repository at this point in the history

  16. Better wording.

    @fnando
    fnando committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    4716384 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Update rubocop rules according to latest release.

    @fnando
    fnando committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    1ab0a38 View commit details
    Browse the repository at this point in the history
Loading