Revert the Trial#complete! public API to support noargs.

Also support passing Goals and a single goal

Author: dekz

lib/split/trial.rb

@@ -26,14 +26,12 @@ def alternative=(alternative)
       end
     end
 
-    def complete!(goals, context = nil)
-      goals = goals || []
-
+    def complete!(goals=[], context = nil)
       if alternative
-        if goals.empty?
+        if Array(goals).empty?
           alternative.increment_completion
         else
-          goals.each {|g| alternative.increment_completion(g) }
+          Array(goals).each {|g| alternative.increment_completion(g) }
         end
 
         context.send(Split.configuration.on_trial_complete, self) \

spec/trial_spec.rb

@@ -109,6 +109,42 @@ def expect_alternative(trial, alternative_name)
       end
     end
 
+    describe "#complete!" do
+      let(:trial) { Split::Trial.new(:user => user, :experiment => experiment) }
+      context 'when there are no goals' do
+        it 'should complete the trial' do
+          trial.choose!
+          old_completed_count = trial.alternative.completed_count
+          trial.complete!
+          expect(trial.alternative.completed_count).to be(old_completed_count+1)
+        end
+      end
+
+      context 'when there are many goals' do
+        let(:goals) { ['first', 'second'] }
+        let(:trial) { Split::Trial.new(:user => user, :experiment => experiment, :goals => goals) }
+        shared_examples_for "goal completion" do
+          it 'should not complete the trial' do
+            trial.choose!
+            old_completed_count = trial.alternative.completed_count
+            trial.complete!(goal)
+            expect(trial.alternative.completed_count).to_not be(old_completed_count+1)
+          end
+        end
+
+        describe 'Array of Goals' do
+          let(:goal) { [goals.first] }
+          it_behaves_like 'goal completion'
+        end
+
+        describe 'String of Goal' do
+          let(:goal) { goals.first }
+          it_behaves_like 'goal completion'
+        end
+
+      end
+    end
+
     describe "alternative recording" do
       before(:each) { Split.configuration.store_override = false }