Skip to content

Commit 206070f

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 45420f8 commit 206070f

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

handwritten/bigtable/cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ steps:
1717
dir: 'handwritten/bigtable'
1818

1919
# 1. Set up Node.js environment
20-
- name: 'node:18'
20+
- name: 'node:24'
2121
entrypoint: 'bash'
2222
args:
2323
- '-c'

handwritten/bigtable/system-test/install.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,13 @@ describe('📦 pack-n-play test', () => {
4343
description: 'JavaScript user can use the library',
4444
// Inject the reference directive at the top of the code
4545
// The reference header is needed so packnplay tests recognize require
46-
ts:
46+
packageDir: process.cwd(),
47+
sample: {
48+
description: 'JavaScript user can use the library',
49+
cjs: readFileSync(
50+
'./system-test/fixtures/sample/src/index.js',
51+
).toString(),
52+
},
4753
'/// <reference types="node" />\n' +
4854
readFileSync('./system-test/fixtures/sample/src/index.js').toString(),
4955
// Still needed so the package actually gets installed in the temp environment

0 commit comments

Comments
 (0)